Update Bazel to 7.1.1, slight cleanup and compatibility improvements #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/bazel-7.1
branch
6 times, most recently
from
eda8fba
to
eb5b9d6
Compare
fhanau
force-pushed
the
felix/bazel-7.1
branch
6 times, most recently
from
4efe1a8
to
ba460a6
Compare
fhanau
force-pushed
the
felix/bazel-7.1
branch
16 times, most recently
from
39337f5
to
9885217
Compare
fhanau
changed the title
7.1 (https://github.com/bazelbuild/bazel/releases/tag/7.1.0) introduces a number of bug fixes and performance improvements, 7.1.1 has some additional bug fixes. - Pass all parameters in kj_test to ensure tags will actually be applied, avoiding a considerable footgun. - Clean up a few globs, allowing us to enable incompatible_disallow_empty_glob - Flip --legacy_external_runfiles early to avoid generating superfluous runfile trees. - Update wd_ts_bundle to fix --legacy_external_runfiles=false for dependents.
hoodmane
approved these changes
Mar 25, 2024
Comment on lines
-12
to
-13
| exclude = [ | ||
| "internal/test/*", |
There was a problem hiding this comment.
Is there a reason you don't want to exclude this anymore?
There was a problem hiding this comment.
Excluding this is not needed – internal/*.{js,ts} covers files in the internal directory, but not the subdirectories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve performance and stability, 7.1 includes a number of performance and correctness improvements for remote caching, sandboxed execution and fetching dependencies.
--experimental_sibling_repository_layoutand--legacy_external_runfilesbazelbuild/bazel#12821 but not required for reviewing this.--legacy_external_runfiles=falsebutbazel aquery --include_file_write_contents=true "deps(//src/workerd/io/...)"shrinks by ~3MB (10%) with the flag so there's certainly less work that bazel needs to do.Commit message: