Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bazel to 7.1.1, slight cleanup and compatibility improvements #1709

Merged
merged 1 commit into from
Mar 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ build --remote_download_all
# Enable webgpu
build --//src/workerd/io:enable_experimental_webgpu=True

# Avoid generating duplicate runfile trees. This will become the default in a future bazel version.
build --legacy_external_runfiles=false

# Flip this early to avoid breaking compatibility once it becomes the default.
build --incompatible_disallow_empty_glob

# Dawn tint build flags
build --@dawn//src/tint:tint_build_glsl_writer=False
build --@dawn//src/tint:tint_build_glsl_validator=False
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.0.2
7.1.1
2 changes: 2 additions & 0 deletions build/kj_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,6 @@ def kj_test(
"@//:use_dead_strip": ["-Wl,-dead_strip", "-Wl,-no_exported_symbols"],
"//conditions:default": [""],
}),
data = data,
tags = tags,
)
4 changes: 2 additions & 2 deletions build/wd_ts_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def wd_ts_bundle(
eslint_bin.eslint_test(
name = name + "@eslint",
args = [
"--config $(execpath {})".format(eslintrc_json),
"--parser-options project:$(execpath {})".format(tsconfig_json),
"--config $(location {})".format(eslintrc_json),
"--parser-options project:$(location {})".format(tsconfig_json),
"-f stylish",
"--report-unused-disable-directives",
] + ["$(location " + src + ")" for src in ts_srcs],
Expand Down
13 changes: 7 additions & 6 deletions src/cloudflare/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ wd_ts_bundle(
"internal/*.ts",
"internal/*.js",
],
exclude = [
"internal/test/*",
Comment on lines -12 to -13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you don't want to exclude this anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding this is not needed – internal/*.{js,ts} covers files in the internal directory, but not the subdirectories.

allow_empty = True,
),
modules = glob(
[
"*.ts",
"*.js",
],
allow_empty = True,
),
modules = glob([
"*.ts",
"*.js",
]),
schema_id = "0xbcc8f57c63814006",
tsconfig_json = "tsconfig.json",
)
5 changes: 1 addition & 4 deletions src/cloudflare/internal/test/d1/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ load("//:build/wd_test.bzl", "wd_test")
wd_test(
src = "d1-api-test.wd-test",
args = ["--experimental"],
data = glob([
"*.js",
"*.capnp",
]),
data = glob(["*.js"]),
)
5 changes: 1 addition & 4 deletions src/cloudflare/internal/test/vectorize/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,5 @@ load("//:build/wd_test.bzl", "wd_test")

wd_test(
src = "vectorize-api-test.wd-test",
data = glob([
"*.js",
"*.capnp",
]),
data = glob(["*.js"]),
)
5 changes: 1 addition & 4 deletions src/workerd/server/tests/unsafe-module/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ load("//:build/wd_test.bzl", "wd_test")
wd_test(
src = "unsafe-module-test.wd-test",
args = ["--experimental"],
data = glob([
"*.js",
"*.capnp",
]),
data = glob(["*.js"]),
)
Loading