Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling fixes. #3461

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Spelling fixes. #3461

merged 3 commits into from
Feb 5, 2025

Conversation

erikcorry
Copy link
Contributor

@erikcorry erikcorry commented Feb 4, 2025 •
edited
Loading

Spelling fixes.

@erikcorry erikcorry requested review from a team as code owners February 4, 2025 18:51
@jclee
Copy link
Contributor

jclee commented Feb 5, 2025

FWIW, a few others I've noticed over time:

  • in comments:
    • s/Search for all knows/Search for all known
    • s/wildcart/wildcard
    • s/heirarchy/hierarchy
    • s/which whish/with which (x2)
  • an internal struct name:
    • s/JsRpcPromiseAndPipleine/JsRpcPromiseAndPipeline
  • a class name:
    • s/RpcSerializerExternalHander/RpcSerializerExternalHandler
  • in a memory tracking string identifier, but guessing it might be OK to fix?:
    • s/SqllitDatabase/SqliteDatabase

@erikcorry erikcorry merged commit 7ab82d8 into main Feb 5, 2025
18 checks passed
@erikcorry erikcorry deleted the erikcorry/spolling branch February 5, 2025 13:36
@erikcorry
Copy link
Contributor Author

Thanks for the suggestions. I rolled some of them into the next change at #3468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jclee jclee jclee left review comments

@mar-cf mar-cf mar-cf approved these changes

@ObsidianMinor ObsidianMinor Awaiting requested review from ObsidianMinor ObsidianMinor is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikcorry @jclee @mar-cf