Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes. #3461

Merged
merged 3 commits into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ build:release_windows --copt="-fstrict-aliasing"
build:windows --cxxopt='/std:c++20' --host_cxxopt='/std:c++20'
build:windows --copt='/D_CRT_USE_BUILTIN_OFFSETOF' --host_copt='/D_CRT_USE_BUILTIN_OFFSETOF'
build:windows --copt='/DWIN32_LEAN_AND_MEAN' --host_copt='/DWIN32_LEAN_AND_MEAN'
# The `/std:c++20` argument is unused during boringssl compilation and we don't
# The `/std:c++20` argument is unused during BoringSSL compilation and we don't
# want a warning when compiling each file.
build:windows --copt='-Wno-unused-command-line-argument' --host_copt='-Wno-unused-command-line-argument'

Expand Down
4 changes: 2 additions & 2 deletions build/deps/deps.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"owner": "google",
"repo": "boringssl",
"branch": "master",
// boringssl may subtly break backwards compatibility and behave differently than the latest
// BoringSSL may subtly break backwards compatibility and behave differently than the latest
// FIPS version, often by rejecting key values that it considers invalid/unsafe even though
// they are still accepted by boringssl. Update with caution and only after confirming this
// they are still accepted by BoringSSL. Update with caution and only after confirming this
// is compatible with the downstream build.
"freeze_commit": "6abe18402eb2a5e9b00158c6459646a948c53060"
},
Expand Down
2 changes: 1 addition & 1 deletion build/perfetto/perfetto_cfg.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ PERFETTO_CONFIG = struct(
proto_library_visibility = "//visibility:private",

# Allow Bazel embedders to change the visibility of the Go protos.
# Go protos have all sorts of strange behaviour in Google3 so need special
# Go protos have all sorts of strange behavior in Google3 so need special
# handling as the rules for other languages do not work for Go.
go_proto_library_visibility = "//visibility:private",

Expand Down
2 changes: 1 addition & 1 deletion build/wd_ts_bundle.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def wd_ts_bundle(
)

if lint:
# todo: lint js_srcs too, not just ts_srcs
# TODO: lint js_srcs too, not just ts_srcs
eslint_bin.eslint_test(
size = "large",
name = name + "@eslint",
Expand Down
2 changes: 1 addition & 1 deletion docs/benchmarking.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ We use a combination of micro and macro benchmarks for performance testing worke
Benchmarks should be built using `--config=benchmark` configuration, which is builds a release
binary with additional debug info.

To obtain most consistent results it is recommended to disable cpu frequency scaling
To obtain most consistent results it is recommended to disable CPU frequency scaling
(use "performance" governor https://wiki.debian.org/CpuFrequencyScaling)

# Micro benchmarks
Expand Down
2 changes: 1 addition & 1 deletion samples/module_fallback/fallback.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const { createServer } = require('http');

const server = createServer((req, res) => {
// The response from the fallback service must be a vaid JSON
// The response from the fallback service must be a valid JSON
// serialization of a Worker::Module config.

// The x-resolve-method tells us if the module was imported or required.
Expand Down
4 changes: 2 additions & 2 deletions src/cloudflare/internal/pipeline-transform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export class PipelineTransformImpl extends entrypoints.WorkerEntrypoint {
#batch?: Batch;
#initalized: boolean = false;

// stub overriden on the sub class
// stub overridden on the sub class
// eslint-disable-next-line @typescript-eslint/require-await
public async transformJson(_data: object[]): Promise<object[]> {
throw new Error('should be implemented by parent');
Expand All @@ -70,7 +70,7 @@ export class PipelineTransformImpl extends entrypoints.WorkerEntrypoint {
// called by the dispatcher which then calls the subclass methods
// @ts-expect-error thinks ping is never used
private _ping(): Promise<void> {
// making sure the function was overriden by an implementing subclass
// making sure the function was overridden by an implementing subclass
if (this.transformJson !== PipelineTransformImpl.prototype.transformJson) {
return Promise.resolve();
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/cloudflare/internal/test/d1/d1-api-test-common.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import * as assert from 'node:assert';

// Recurse through nested objects/arrays looking for 'anything' and deleting that
// key/value from both objects. Gives us a way to get expect.toMatchObject behaviour
// key/value from both objects. Gives us a way to get expect.toMatchObject behavior
// with only deepEqual
const anything = Symbol('anything');
const deleteAnything = (expected, actual) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ async function testD1ApiWithSessionsOldTokensSkipped(DB, envD1MockFetcher) {
tokensFromEyeball[1],
// We skip the commit token "------", since the previously received one was more recent.
tokensFromEyeball[1],
// The binding then sents back the next largest value.
// The binding then sends back the next largest value.
tokensFromEyeball[3],
];
assert.deepEqual(tokensFromBinding, expectedTokensFromBinding);
Expand Down
2 changes: 1 addition & 1 deletion src/cloudflare/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"moduleResolution": "node",
"declaration": true,
"types": [
// todo: consume generated workerd types
// TODO: consume generated workerd types
// "@cloudflare/workers-types"
],
"paths": {
Expand Down
2 changes: 1 addition & 1 deletion src/node/crypto.ts
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export function getCurves(): string[] {
}

export function getHashes(): string[] {
// Hardcoded list of hashes supported in boringssl, node's approach looks pretty clunky. This is
// Hardcoded list of hashes supported in BoringSSL, node's approach looks pretty clunky. This is
// expected to change infrequently based of bssl's stability-focused approach.

// prettier-ignore
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_dh.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_hash.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { default as cryptoImpl } from 'node-internal:crypto';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_hkdf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { Buffer } from 'node-internal:internal_buffer';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_pbkdf2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_random.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { default as cryptoImpl } from 'node-internal:crypto';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_scrypt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_spkac.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { default as cryptoImpl } from 'node-internal:crypto';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

'use strict';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/crypto_x509.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { default as cryptoImpl, CheckOptions } from 'node-internal:crypto';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/debuglog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { format, formatWithOptions } from 'node-internal:internal_inspect';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/diagnostics_channel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the Apache 2.0 license found in the LICENSE file or at:
// https://opensource.org/licenses/Apache-2.0
//
/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { AsyncLocalStorage } from 'node-internal:async_hooks';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/events.ts
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ function emitUnhandledRejectionOrErr(
// we might end up in an infinite loop.
const prev = ee[kCapture];

// If the error handler throws, it is not catcheable and it
// If the error handler throws, it is not catchable and it
// will end up in 'uncaughtException'. We restore the previous
// value of kCapture in case the uncaughtException is present
// and the exception is handled.
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_assertionerror.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { ERR_INVALID_ARG_TYPE } from 'node-internal:internal_errors';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_buffer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// Copyright Joyent and Node contributors. All rights reserved. MIT license.
// Copyright Feross Aboukhadijeh, and other contributors. All rights reserved. MIT license.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import {
Expand Down
4 changes: 2 additions & 2 deletions src/node/internal/internal_comparisons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { compare } from 'node-internal:internal_buffer';
Expand Down Expand Up @@ -176,7 +176,7 @@ function innerDeepEqual(
} else {
if (val1 === null || typeof val1 !== 'object') {
if (val2 === null || typeof val2 !== 'object') {
// todo: eslint-disable-next-line eqeqeq
// TODO: eslint-disable-next-line eqeqeq
return val1 == val2 || (Number.isNaN(val1) && Number.isNaN(val2));
}
return false;
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_diffs.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
// This module is browser compatible.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

interface FarthestPoint {
Expand Down
6 changes: 3 additions & 3 deletions src/node/internal/internal_inspect.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import internalWorkers from 'cloudflare-internal:workers';
Expand Down Expand Up @@ -2013,7 +2013,7 @@ function formatPrimitive(
}
if (
ctx.compact !== true &&
// We do not support handling unicode characters width with
// We do not support handling Unicode characters width with
// the readline getStringWidth function as there are
// performance implications.
value.length > kMinLineLength &&
Expand Down Expand Up @@ -2475,7 +2475,7 @@ function isBelowBreakLength(
// Each entry is separated by at least a comma. Thus, we start with a total
// length of at least `output.length`. In addition, some cases have a
// whitespace in-between each other that is added to the total as well.
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
// TODO(BridgeAR): Add Unicode support. Use the readline getStringWidth
// function. Check the performance overhead and make it an opt-in in case it's
// significant.
let totalLength = output.length + start;
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_path.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1238,7 +1238,7 @@ const posix = {
* @returns {string}
*/
toNamespacedPath(path: string): string {
// Non-op on posix systems
// No-op on Posix systems
return path;
},

Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/internal_stringdecoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { Buffer } from 'node-internal:internal_buffer';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/mock.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import {
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_adapters.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */
import { Readable } from 'node-internal:streams_readable';

Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_compose.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { pipeline } from 'node-internal:streams_pipeline';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_duplex.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { Readable } from 'node-internal:streams_readable';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { EventEmitter } from 'node-internal:events';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_pipeline.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import {
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { isIterable, isNodeStream, finished } from 'node-internal:streams_util';
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_readable.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import {
Expand Down
2 changes: 1 addition & 1 deletion src/node/internal/streams_transform.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ SOFTWARE. */

// Derived from DefinitelyTyped https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/stream.d.ts#L1060

/* todo: the following is adopted code, enabling linting one day */
/* TODO: the following is adopted code, enabling linting one day */
/* eslint-disable */

import { EventEmitter } from 'node:events';
Expand Down
Loading