Add support for multiple and weak etags in R2 bindings #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Apr 24, 2023
jasnell
reviewed
Apr 24, 2023
Frederik-Baetens
force-pushed
the
fbaetens/r2_etag_parsing
branch
6 times, most recently
from
944b70d to
854e253
Compare
jasnell
approved these changes
Apr 26, 2023
bthwaites
reviewed
Apr 27, 2023
Frederik-Baetens
force-pushed
the
fbaetens/r2_etag_parsing
branch
3 times, most recently
from
42b339a to
5541015
Compare
jasnell
reviewed
Apr 28, 2023
jasnell
reviewed
Apr 28, 2023
Frederik-Baetens
force-pushed
the
fbaetens/r2_etag_parsing
branch
2 times, most recently
from
5f6f271 to
6f0002c
Compare
Previously users could pass http headers to Get/PutObject in the bindings, however we only accepted a single strong etag. This commit adds support for weak etags, wildcards, and multiple etags in the if-match and if-none-match http headers.
Frederik-Baetens
force-pushed
the
fbaetens/r2_etag_parsing
branch
from
6f0002c to
281eacc
Compare
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
May 12, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
May 12, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/miniflare
that referenced
this pull request
May 15, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Oct 31, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
cloudflare/workerd#563 added support to R2 bindings for these
mrbbot
added a commit
to cloudflare/workers-sdk
that referenced
this pull request
Nov 1, 2023
cloudflare/workerd#563 added support to R2 bindings for these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously users could pass http headers to Get/PutObject in the bindings, however we only accepted a single strong etag. This commit adds support for weak etags, wildcards, and multiple etags in the if-match and if-none-match http headers.
Internal PR to come soon after.Internal PR is up