maintenance: wrangler depends on deprecated npm package rollup-plugin-inject
#1232
Assignees
Labels
Milestone
Comments
|
This is an upstream issue on the dependency chain we use for node-compat:
See ionic-team/rollup-plugin-node-polyfills#32. Perhaps we could switch to https://github.com/niksy/node-stdlib-browser instead of @esbuild-plugins/node-modules-polyfill? |
threepointone
added
maintenance
threepointone
changed the title
rollup-plugin-injectrollup-plugin-inject
|
This and sourcemap-codec are still WARNing as deprecated as at July 2023. |
|
Why is this not getting looked at? When I first started using wrangler I thought i installed the wrong SDK because I got all these warnings, seems a bit sloppy to me |
IgorMinar
added
the
breaking change
|
Updating this version will likely result in a breaking change that might affect unknown (but hopefully only small) number of use-cases. That shouldn't prevent us from updating this. We'll consider this as a change that we'll bundle with a few other minor breaking changes in a future version. |
|
@IgorMinar, just curious, is #3832 (PR to close this issue) more of a breaking change than #3772 (released in For convenience: the breaking change in #3772:
(apologies if this isn't a useful question) |
|
@mrienstra The version of esbuild we bumped to in #3772 was carefully considered so as not to potentially introduce any user-facing breaking changes. Notably, we didn't bump to esbuild@0.18+ since that version includes changes to build output that might affect users in unforeseen ways. We're planning on also making that bump in the next major version of wrangler (#3962) |
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this issue
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this issue
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this issue
Mar 8, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
that referenced
this issue
Mar 9, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves #1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this issue
Mar 13, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
petebacondarwin
pushed a commit
to MichaelDeBoey/workers-sdk
that referenced
this issue
Mar 16, 2024
Replaces `@esbuild-plugins/node-globals-polyfill` & `@esbuild-plugins/node-modules-polyfill` with the up-to-date & maintained `esbuild-plugins-node-modules-polyfill` The `esbuild-plugins` repository actually points towards using `esbuild-plugin-polyfill-node` instead https://github.com/remorses/esbuild-plugins/blob/373b44902ad3e669f7359c857de09a930ce1ce90/README.md?plain=1#L15-L16 But the Remix repo (see remix-run/remix#5274) tried this and found some regressions. So they chose to go for @imranbarbhuiya's `esbuild-plugins-node-modules-polyfill` instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative. Users should no longer see the following deprecation warnings when installing Wrangler: ```sh npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject. npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead ``` Resolves cloudflare#1232
|
We've landed the update to esbuild plugins into the v4 branch so closing this as complete. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of
Wranglerare you using?2.0.9
What operating system are you using?
mac
Describe the Bug
Can you please upgrade to the supported package?
The text was updated successfully, but these errors were encountered: