Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update esbuild to v0.18.20 #3962

Closed
jspspike opened this issue Sep 15, 2023 · 4 comments · Fixed by #5213
Closed

Update esbuild to v0.18.20 #3962

jspspike opened this issue Sep 15, 2023 · 4 comments · Fixed by #5213
Assignees
@mrbbot
Labels
breaking change Change that will result in breaking existing behavior
Milestone
Wrangler v4

Comments

@jspspike
Copy link
Contributor

Describe the solution

Update esbuild on next major wrangler update. We can update to 19 once this issue gets resolved
@jspspike jspspike added the breaking change Change that will result in breaking existing behavior label Sep 15, 2023
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 28, 2023
@1000hz 1000hz mentioned this issue Oct 2, 2023
Closed
@lrapoport-cf lrapoport-cf moved this from Untriaged to Backlog in workers-sdk Oct 9, 2023
@penalosa penalosa mentioned this issue Nov 8, 2023
Merged
4 tasks
@penalosa penalosa mentioned this issue Nov 20, 2023
Closed
@admah admah added this to the Wrangler v4 milestone Feb 13, 2024
@admah
Copy link
Contributor

admah commented Feb 23, 2024

The latest esbuild is 0.20.1. Are we still limited to 0.18+?

@GregBrimble
Copy link
Member

Until that issue is resolved, yes. Has anyone in DevProd looked into putting up a PR against esbuild?

@mrbbot mrbbot mentioned this issue Mar 8, 2024
Merged
9 tasks
@mrbbot
Copy link
Contributor

mrbbot commented Mar 11, 2024 •
edited
Loading

Has anyone in DevProd looked into putting up a PR against esbuild?

@GregBrimble yep, we did look into this. Looks like a PR to add a flag to disable the behaviour would be doable, but we weren't sure whether it would be accepted. There are other options too like trying to pass glob patterns/import specifiers through onResolve plugin hooks, but that would be more complicated to implement. Our plan was to bump to 0.18.20 now, then try bump further if we have time. 👍

@mrbbot
Copy link
Contributor

mrbbot commented Mar 11, 2024

I've written up some thoughts on upgrading to 0.19.0 and beyond here: #5222.

@petebacondarwin petebacondarwin moved this from Backlog to In Progress in workers-sdk Mar 11, 2024
@mrbbot mrbbot linked a pull request Mar 14, 2024 that will close this issue
feature: bump esbuild to 0.18.20 #5213
Merged
9 tasks
@lrapoport-cf lrapoport-cf moved this from In Progress to In Review in workers-sdk Mar 15, 2024
@petebacondarwin petebacondarwin moved this from In Review to Done in workers-sdk Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrbbot mrbbot

Labels
breaking change Change that will result in breaking existing behavior
Projects
None yet
Milestone
Wrangler v4
Development

Successfully merging a pull request may close this issue.

feature: bump esbuild to 0.18.20 cloudflare/workers-sdk
5 participants
@petebacondarwin @admah @jspspike @GregBrimble @mrbbot