Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: bump esbuild to 0.18.20 #5213

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feature: bump esbuild to 0.18.20 #5213

merged 1 commit into from
Mar 15, 2024

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Mar 8, 2024

What this PR solves / how to test

Fixes #3962. This PR bumps esbuild to version 0.18.20 across the monorepo. We can't go any further because of these issues. We investigated what it would take to workaround/fix this. I'll open a separate ticket with our findings, and to track upgrading further. 👍

Author has addressed the following

@mrbbot mrbbot requested a review from a team as a code owner March 8, 2024 19:30
Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: f77a3e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-wrangler-5213

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5213/npm-package-wrangler-5213

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-wrangler-5213 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-create-cloudflare-5213 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-cloudflare-kv-asset-handler-5213
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-miniflare-5213
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-cloudflare-pages-shared-5213
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8300317697/npm-package-cloudflare-vitest-pool-workers-5213

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.31.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240223.1
workerd 1.20240304.0 1.20240304.0
workerd --version 1.20240304.0 2024-03-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4@0990c28). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##             v4    #5213   +/-   ##
=====================================
  Coverage      ?   70.44%           
=====================================
  Files         ?      296           
  Lines         ?    15602           
  Branches      ?     4009           
=====================================
  Hits          ?    10991           
  Misses        ?     4611           
  Partials      ?        0           
Files Coverage Δ
.../wrangler/src/deployment-bundle/bundle-reporter.ts 97.61% <100.00%> (ø)
packages/wrangler/src/deployment-bundle/bundle.ts 88.52% <100.00%> (ø)

@mrbbot mrbbot force-pushed the bcoll/v4-esbuild-bump branch 2 times, most recently from bd12bf8 to c710265 Compare March 11, 2024 11:56
@mrbbot mrbbot requested a review from a team as a code owner March 11, 2024 11:56
@mrbbot mrbbot linked an issue Mar 14, 2024 that may be closed by this pull request
@petebacondarwin petebacondarwin added the e2e Run e2e tests on a PR label Mar 14, 2024
@petebacondarwin
Copy link
Contributor

Rerunning Windows e2e test to ensure it was just a flake

@mrbbot mrbbot force-pushed the bcoll/v4-esbuild-bump branch from c710265 to f77a3e3 Compare March 15, 2024 17:49
@mrbbot mrbbot changed the title chore: bump esbuild to 0.18.20 feature: bump esbuild to 0.18.20 Mar 15, 2024
@mrbbot mrbbot merged commit defb3d5 into v4 Mar 15, 2024
17 checks passed
@mrbbot mrbbot deleted the bcoll/v4-esbuild-bump branch March 15, 2024 18:21
petebacondarwin pushed a commit that referenced this pull request Mar 16, 2024
GregBrimble pushed a commit that referenced this pull request Apr 4, 2024
GregBrimble pushed a commit that referenced this pull request Apr 4, 2024
GregBrimble pushed a commit that referenced this pull request Apr 4, 2024
RamIdeas pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update esbuild to v0.18.20
2 participants