Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify zoned workers work in dev/publish #301

Closed
7 of 8 tasks
Tracked by #12
petebacondarwin opened this issue Jan 25, 2022 · 2 comments
Closed
7 of 8 tasks
Tracked by #12

verify zoned workers work in dev/publish #301

petebacondarwin opened this issue Jan 25, 2022 · 2 comments
Labels
maintenance Maintenance task

Comments

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Jan 25, 2022

Steps to check:

  • Create a project with routes in wrangler.toml
  • Check wrangler publish
    • if you specify a route at the command line (via --route) it overrides anything in the wrangler.toml (rather than the union of routes)
    • the workers_dev setting defaults to true, so the xxx.workers.dev route is always, also, deployed
    • workers_dev = false appears to have no effect when it comes to publishing
    • if you specify a route (viawrangler.toml or --route) that has not been configured for DNS, then it will still "deploy" but of course the URL will not work. We should look into updating the DNS automatically as part of the deployment.
  • Check wrangler dev
    • Dev mode works as expected - it published to a preview worker and any zoned route is effectively ignored, AFAICT.
  • Check durable_objects support for dev and publish #563
  • Deprecate zone_id config - it should just come from routes
  • Automatically setup a subdomain if it doesn't exist #511
    • or to give guidance on how to do this
@petebacondarwin petebacondarwin mentioned this issue Jan 25, 2022
27 tasks
@petebacondarwin petebacondarwin moved this to Blocking in workers-sdk Jan 25, 2022
@petebacondarwin petebacondarwin self-assigned this Jan 25, 2022
@Electroid Electroid added the maintenance Maintenance task label Jan 25, 2022
@petebacondarwin
Copy link
Contributor Author

The counterpart to this issue is #318

@petebacondarwin petebacondarwin added this to the Wrangler 2.0 milestone Feb 1, 2022
@petebacondarwin petebacondarwin moved this from Blocking to In Progress in workers-sdk Feb 1, 2022
@petebacondarwin
Copy link
Contributor Author

Unassigning myself as I have captured most of the outstanding concerns in other issues.

@petebacondarwin petebacondarwin removed their assignment Mar 9, 2022
@petebacondarwin petebacondarwin moved this from In Progress to Should-have in workers-sdk Mar 9, 2022
Repository owner moved this from Should-have to Done in workers-sdk Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task
Projects
None yet
Development

No branches or pull requests

2 participants