Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Disabling workers dev domain doesn't work #410

Closed
isaac-mcfadyen opened this issue Feb 8, 2022 · 1 comment · Fixed by #458 or #407
Closed

🐛 BUG: Disabling workers dev domain doesn't work #410

isaac-mcfadyen opened this issue Feb 8, 2022 · 1 comment · Fixed by #458 or #407
Assignees
@petebacondarwin

Comments

@isaac-mcfadyen
Copy link
Contributor

isaac-mcfadyen commented Feb 8, 2022 •
edited
Loading

What version of Wrangler are you using?

alpha (14098af)

What operating system are you using?

MacOS

Describe the Bug

When adding workers_dev = false to wrangler.toml and instead using a custom domain with routes, the dev domain is still enabled and able to be used to receive requests. This is not desired behavior.
@Electroid Electroid added this to the 2.0 milestone Feb 8, 2022
@petebacondarwin
Copy link
Contributor

I concur with this - I noted it also in #301

@petebacondarwin petebacondarwin moved this to Blocking in workers-sdk Feb 8, 2022
@petebacondarwin petebacondarwin self-assigned this Feb 13, 2022
petebacondarwin added a commit that referenced this issue Feb 14, 2022
@petebacondarwin
fix: do not publish to workers.dev if workers_dev is false
b98713e 
Previously we always published to the workers.dev subdomain, ignoring the `workers_dev` setting in the `wrangler.toml` configuration.

Now we respect this configuration setting, and also disable an current workers.dev subdomain worker when we publish and `workers_dev` is `false`.

Fixes #410
@petebacondarwin petebacondarwin mentioned this issue Feb 14, 2022
Merged
petebacondarwin added a commit that referenced this issue Feb 14, 2022
@petebacondarwin
fix: do not publish to workers.dev if workers_dev is false
b73133a 
Previously we always published to the workers.dev subdomain, ignoring the `workers_dev` setting in the `wrangler.toml` configuration.

Now we respect this configuration setting, and also disable an current workers.dev subdomain worker when we publish and `workers_dev` is `false`.

Fixes #410
@petebacondarwin petebacondarwin moved this from Must-have to In Review in workers-sdk Feb 14, 2022
petebacondarwin added a commit that referenced this issue Feb 14, 2022
@petebacondarwin
fix: do not publish to workers.dev if workers_dev is false
a8f97e5 
Previously we always published to the workers.dev subdomain, ignoring the `workers_dev` setting in the `wrangler.toml` configuration.

Now we respect this configuration setting, and also disable an current workers.dev subdomain worker when we publish and `workers_dev` is `false`.

Fixes #410
Repository owner moved this from In Review to Done in workers-sdk Feb 14, 2022
@github-actions github-actions bot mentioned this issue Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@petebacondarwin @Electroid @isaac-mcfadyen