fix: do not publish to workers.dev if workers_dev is false #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b73133a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
In f9c1423 the query param was incorrectly changed from `available_on_subdomain` to `available_on_subdomains`. It is not clear if this makes any difference as I cannot find anywhere in the config service that expects such a query parameter.
Previously we always published to the workers.dev subdomain, ignoring the `workers_dev` setting in the `wrangler.toml` configuration. Now we respect this configuration setting, and also disable an current workers.dev subdomain worker when we publish and `workers_dev` is `false`. Fixes #410
petebacondarwin
force-pushed
the
workers_dev
branch
from
b98713e
to
b73133a
Compare
|
wrangler prerelease is available for testing: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1840163567/wrangler |
|
Thanks for fixing what I broke! 😬 |
threepointone
approved these changes
Feb 14, 2022
Merged
Closed
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always published to the workers.dev subdomain, ignoring the
workers_devsetting in thewrangler.tomlconfiguration.Now we respect this configuration setting, and also disable an current workers.dev subdomain worker when we publish and
workers_devisfalse.Fixes #410