Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give an actionable error message when running wrangler publish without a workers.dev zone defined #318

Closed
Electroid opened this issue Jan 27, 2022 · 7 comments · Fixed by #568
Closed

Give an actionable error message when running wrangler publish without a workers.dev zone defined #318

Electroid opened this issue Jan 27, 2022 · 7 comments · Fixed by #568
Assignees
@caass
Labels
maintenance Maintenance task polish Small improvements to the experience

Comments

@Electroid
Copy link
Contributor

There are many accounts that don't have a workers.dev zone (and some that don't want to enable it as well). We need to make sure dev, publish, and the other commands that touch the deployment cycle still work without one.
@Electroid Electroid added the maintenance Maintenance task label Jan 27, 2022
@petebacondarwin petebacondarwin mentioned this issue Jan 27, 2022
Closed
8 tasks
@Electroid Electroid added this to the 2.0 milestone Feb 3, 2022
@Electroid Electroid moved this to Blocking in workers-sdk Feb 7, 2022
@petebacondarwin
Copy link
Contributor

petebacondarwin commented Mar 2, 2022 •
edited
Loading

The short term fix is to show an error if they have no workers.dev (subdomain) zone, and describe how they can go create it.

A longer term fix is to ask the user if they would like us to actually create the zone for them, captured in a new issue see #535.

@petebacondarwin petebacondarwin changed the title Ensure publish works without a workers.dev zone Give an actionable error message when running wrangler publish without a workers.dev zone defined Mar 2, 2022
@petebacondarwin petebacondarwin mentioned this issue Mar 2, 2022
Closed
@petebacondarwin petebacondarwin added the polish Small improvements to the experience label Mar 2, 2022
@petebacondarwin petebacondarwin moved this from Must-have to In Progress in workers-sdk Mar 2, 2022
@threepointone
Copy link
Contributor

There are two separate issues here

@petebacondarwin
Copy link
Contributor

This issue is now about a quick UX improvement to the situation. Currently the error messages are obscure, confusing and not-actionable.
The other issue #535 is to cover the case where a user would like to have a workers.dev subdomain but hasn't yet created one. In that case we should help make it for them automatically.
What I think you are referring to is a third issue, which is to allow wrangler dev to work without ever having to provide a route or a worker.dev subdomain.

@threepointone threepointone mentioned this issue Mar 4, 2022
Closed
@threepointone
Copy link
Contributor

Pete and I discussed this, and I shared that we haven't yet implemented wrangler dev support for zoned workers, and it currently uses the same codepath as workers.dev workers (which errors as expected). We should still have better errors/messaging, but I also filed #544 to track actually implementing wrangler dev for zoned workers.

@caass caass mentioned this issue Mar 10, 2022
Merged
threepointone pushed a commit that referenced this issue Mar 11, 2022
Add a nicer error when there's no workers.dev subdomain (#568)
b6f2266 
Show an actionable error message when publishing to a workers.dev subdomain that hasn't been created yet.

When publishing a worker to workers.dev, you need to first have registered your workers.dev subdomain
(e.g. my-subdomain.workers.dev). We now check to ensure that the user has created their subdomain before
uploading a worker to workers.dev, and if they haven't, we provide a link to where they can go through
the workers onboarding flow and create one.

Closes #318
Repository owner moved this from In Progress to Done in workers-sdk Mar 11, 2022
@threepointone threepointone reopened this Mar 11, 2022
Repository owner moved this from Done to In Progress in workers-sdk Mar 11, 2022
@threepointone
Copy link
Contributor

Reopeneing this, we still need to verify whether wrangler2 works on zoned workers for folks who explicitly don't want to register a workers.dev subdomain

@petebacondarwin
Copy link
Contributor

I believe that @caass has verified that we can publish to a zoned worker (as long as routes are configured) even if there is no workers.dev subdomain configured.

@threepointone
Copy link
Contributor

Dope. Alright, closing this

Repository owner moved this from In Progress to Done in workers-sdk Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caass caass

Labels
maintenance Maintenance task polish Small improvements to the experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a nicer error when there's no workers.dev subdomain cloudflare/workers-sdk
4 participants
@petebacondarwin @threepointone @Electroid @caass