Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-cloudflare): telemetry collection #6484

Merged
merged 26 commits into from
Sep 23, 2024
Merged

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Aug 13, 2024

What this PR solves / how to test

Fixes DEVX-1390
Approved as part of CR-995529

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation

Copy link

changeset-bot bot commented Aug 13, 2024

🦋 Changeset detected

Latest commit: 18ee533

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-wrangler-6484

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6484/npm-package-wrangler-6484

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-wrangler-6484 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-create-cloudflare-6484 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-cloudflare-kv-asset-handler-6484
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-miniflare-6484
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-cloudflare-pages-shared-6484
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-cloudflare-vitest-pool-workers-6484
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-cloudflare-workers-editor-shared-6484
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10991981222/npm-package-cloudflare-workers-shared-6484

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.78.7 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry branch 4 times, most recently from 502cb70 to cf9827e Compare August 22, 2024 10:57
@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry branch 2 times, most recently from d952ca6 to 8265321 Compare September 2, 2024 18:12
@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry branch 2 times, most recently from fa5f658 to 2b6c442 Compare September 6, 2024 11:36
@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry branch 4 times, most recently from d7d75dd to 0942809 Compare September 10, 2024 14:51
Copy link
Contributor

@RamIdeas RamIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to remove the SPARROW_SOURCE_KEY from the prerelease workflow before merging

@edmundhung edmundhung force-pushed the edmundhung/c3-telemetry branch 4 times, most recently from a50cc6a to b98122e Compare September 16, 2024 16:49
nevikashah and others added 3 commits September 20, 2024 09:52
Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
Co-authored-by: lrapoport-cf <107272160+lrapoport-cf@users.noreply.github.com>
@edmundhung edmundhung marked this pull request as ready for review September 20, 2024 14:08
@edmundhung edmundhung requested review from a team as code owners September 20, 2024 14:08
@edmundhung edmundhung merged commit 5632968 into main Sep 23, 2024
29 checks passed
@edmundhung edmundhung deleted the edmundhung/c3-telemetry branch September 23, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants