-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(create-cloudflare): provide SPARROW_SOURCE_KEY on pre-release and publish build #6807
Conversation
|
@@ -33,6 +33,9 @@ jobs: | |||
run: pnpm run build | |||
env: | |||
CI_OS: ${{ runner.os }} | |||
# This is the "production" key for sparrow analytics. | |||
# This is needed for create-cloudflare | |||
SPARROW_SOURCE_KEY: "50598e014ed44c739ec8074fdc16057c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrangler will rebuild on publish on a later step, click here to see the publish step.
@@ -40,6 +40,9 @@ jobs: | |||
env: | |||
NODE_ENV: "production" | |||
CI_OS: ${{ runner.os }} | |||
# this is the "test/staging" key for sparrow analytics | |||
# This is needed for create-cloudflare | |||
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrangler will re-build on publish later, click here to see the publish step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my understanding...why is one workflow using prod and the other staging?
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-wrangler-6807 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6807/npm-package-wrangler-6807 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-wrangler-6807 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-create-cloudflare-6807 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-cloudflare-kv-asset-handler-6807 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-miniflare-6807 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-cloudflare-pages-shared-6807 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-cloudflare-vitest-pool-workers-6807 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-cloudflare-workers-editor-shared-6807 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10999209560/npm-package-cloudflare-workers-shared-6807 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
I make a wrong assumption that only |
Followup PR: #6808 |
What this PR solves / how to test
Fixes #6484.
We merged #6484 today and thought that the current build setup should be sufficient as both
wrangler
andcreate-cloudflare
rely on the same envSPARROW_SOURCE_KEY
. Unfortunately, wrangler does an additional re-build before publish and the current setup inject the env only on the publish step instead of during the build.This is a quick fix to enable telemetry in c3. We should removes the need to set the env on both steps in the future.
Author has addressed the following