Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure GitHub Actions to deploy Asset Worker #6542

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Configure GitHub Actions to deploy Asset Worker #6542

merged 1 commit into from
Sep 11, 2024

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Aug 21, 2024 •
edited by CarmenPopoviciu
Loading

What this PR solves / how to test

Configure GitHub Actions to deploy Asset Worker

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: GH action change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: GH action change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: internal facing change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal facing change

@GregBrimble GregBrimble requested a review from a team as a code owner August 21, 2024 06:00
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 484909c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-wrangler-6542

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6542/npm-package-wrangler-6542

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-wrangler-6542 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-create-cloudflare-6542 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-cloudflare-kv-asset-handler-6542
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-miniflare-6542
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-cloudflare-pages-shared-6542
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-cloudflare-vitest-pool-workers-6542
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-cloudflare-workers-editor-shared-6542
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10812653577/npm-package-cloudflare-workers-shared-6542

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

This was referenced Aug 21, 2024
Merged
Merged
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/asw2 branch 8 times, most recently from eed70a0 to 786c1a7 Compare August 23, 2024 08:04
Base automatically changed from carmen/asw2 to main August 23, 2024 10:42
@GregBrimble GregBrimble closed this Sep 6, 2024
@GregBrimble GregBrimble reopened this Sep 6, 2024
@petebacondarwin petebacondarwin changed the title Configure GitHub Actions to deploy asw2 Configure GitHub Actions to deploy Asset Worker Sep 11, 2024
penalosa
penalosa requested changes Sep 11, 2024
View reviewed changes
packages/workers-shared/package.json Outdated Show resolved Hide resolved
@CarmenPopoviciu CarmenPopoviciu merged commit 81c40f0 into main Sep 11, 2024
21 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the asw2-deploy branch September 11, 2024 14:03
andyjessop added a commit that referenced this pull request Sep 13, 2024
@andyjessop
Merge branch 'main' into bib/remove-wrangler-generate
47da56a 
* main:
  Add pipeline binding to wrangler.toml (#6674)
  Fix Pages duplicating hash in redirects (#6680)
  Bradley/r2 event notification get (#6652)
  feat(wrangler): Add support for placement hints (#6625)
  fix(wrangler): Validate `routes` for Workers with assets (#6621)
  chore(deps): bump the workerd-and-workers-types group across 1 directory with 2 updates (#6673)
  chore(workers-shared): Configure GitHub Actions to deploy Asset Worker (#6542)
  feat: experimental workers assets can be ignored by adding a .assetsignore file (#6640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

@penalosa penalosa penalosa approved these changes

@edmundhung edmundhung edmundhung approved these changes

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GregBrimble @petebacondarwin @CarmenPopoviciu @edmundhung @penalosa