Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GitHub Actions to deploy Router Worker #6543

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Aug 21, 2024

Will conflict at packages/workers-shared/package.json#scripts.deploy with #6542

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: GH actions change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: GH actions change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: internal facing change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal facing change

@GregBrimble GregBrimble requested a review from a team as a code owner August 21, 2024 06:30
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 56a3866

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from emily/router-worker to main August 22, 2024 09:27
@GregBrimble GregBrimble closed this Sep 6, 2024
@GregBrimble GregBrimble reopened this Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 11, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-wrangler-6543

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6543/npm-package-wrangler-6543

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-wrangler-6543 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-create-cloudflare-6543 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-cloudflare-kv-asset-handler-6543
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-miniflare-6543
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-cloudflare-pages-shared-6543
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-cloudflare-vitest-pool-workers-6543
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-cloudflare-workers-editor-shared-6543
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10814062316/npm-package-cloudflare-workers-shared-6543

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.76.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu changed the title Configure GitHub Actions to deploy router-worker Configure GitHub Actions to deploy Router Worker Sep 11, 2024
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CarmenPopoviciu CarmenPopoviciu merged commit a027c1f into main Sep 12, 2024
21 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the router-worker-actions branch September 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants