-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cfdot actual-lrps
consistent
#64
Merged
geofffranks
merged 1 commit into
cloudfoundry:main
from
MarcPaquette:183842469-HostTlsProxyPort-consistency
Apr 18, 2023
Merged
Make cfdot actual-lrps
consistent
#64
geofffranks
merged 1 commit into
cloudfoundry:main
from
MarcPaquette:183842469-HostTlsProxyPort-consistency
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Deploy an app on CF 2. ssh into the diego cell that the app is running on 3. Run `cfdot actual-lrps` In the port section, each array entry should have 4 attributes. If there's no correpsonding port, it should list `0` as the port. ``` "ports": [ { "container_port": 8080, "host_port": 61004, "container_tls_proxy_port": 61001, "host_tls_proxy_port": 61006 }, { "container_port": 8080, "host_port": 61004, "container_tls_proxy_port": 61443, "host_tls_proxy_port": 0 }, { "container_port": 2222, "host_port": 61005, "container_tls_proxy_port": 61002, "host_tls_proxy_port": 61007 } ], ``` For the C2CTLS port (61443), there is no entry for `host_tls_proxy_port`. This should be set to 0 in all cases (regardless of whether the values of the `containers.proxy.enable_unproxied_port_mappings` and `containers.proxy.require_and_verify_client_certificates` properties are set) ``` { "process_guid": "4a295375-84d5-4017-8e14-97cc08fef7e6-f257d4b3-e810-4ad9-bfbe-f493dcddddb0", "index": 0, "domain": "cf-apps", "instance_guid": "6f042458-693c-456a-6fa6-ed96", "cell_id": "e0c33815-b521-4e83-bc43-a8fb41d29ea7", "address": "10.0.1.14", "ports": [ { "container_port": 8080, "host_port": 61000, "container_tls_proxy_port": 61001, "host_tls_proxy_port": 61002 }, { "container_port": 8080, "host_port": 61000, "container_tls_proxy_port": 61443 }, { "container_port": 2222, "host_port": 61001, "container_tls_proxy_port": 61002, "host_tls_proxy_port": 61003 } ], ```
notrepo05
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on this, but the removal of omitempty
does seem to satisfy the requirements
dsabeti
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winkingturtle-vmw
added a commit
to cloudfoundry/rep
that referenced
this pull request
Apr 20, 2023
Context: cloudfoundry/bbs#64
winkingturtle-vmw
added a commit
to cloudfoundry/rep
that referenced
this pull request
Apr 20, 2023
Context: cloudfoundry/bbs#64
winkingturtle-vmw
added a commit
to cloudfoundry/rep
that referenced
this pull request
Apr 20, 2023
* Fix tests Context: cloudfoundry/bbs#64 * Add distributed tracing. Signed-off-by: Brandon Roberson <broberson@vmware.com> Signed-off-by: Nick Rohn <nrohn@vmware.com> * Remove logger from EvacuationHandler there seems to be no code-path that would do any logging for evacuation_handler --------- Signed-off-by: Brandon Roberson <broberson@vmware.com> Signed-off-by: Nick Rohn <nrohn@vmware.com>
winkingturtle-vmw
added a commit
to cloudfoundry/route-emitter
that referenced
this pull request
Apr 20, 2023
Context: cloudfoundry/bbs#64
geofffranks
pushed a commit
to cloudfoundry/route-emitter
that referenced
this pull request
Apr 20, 2023
Context: cloudfoundry/bbs#64
MarcPaquette
added a commit
to MarcPaquette/community
that referenced
this pull request
May 25, 2023
…prover Diego Approver cloudfoundry/bbs#64 cloudfoundry/bbs#68 cloudfoundry/diego-dockerfiles@3aa03b8 cloudfoundry/diego-dockerfiles@77dccfa cloudfoundry/diego-dockerfiles@c69911c cloudfoundry/diego-dockerfiles@df0aed2 cloudfoundry/diego-release@05dcaba cloudfoundry/diego-release@390d5d7 cloudfoundry/diego-release@4d5e6a1 cloudfoundry/diego-release@5158007 cloudfoundry/diego-release#740 cloudfoundry/docs-cloudfoundry-concepts#181 cloudfoundry/dontpanic#39 cloudfoundry/executor#76 cloudfoundry/executor#80 cloudfoundry/grace#3 cloudfoundry/healthchecker-release#2 cloudfoundry/wg-app-platform-runtime-ci@03fa33d cloudfoundry/wg-app-platform-runtime-ci@3affeda PR Reviews: cloudfoundry/buildpackapplifecycle#55 cloudfoundry/cacheddownloader#18 cloudfoundry/diego-release#689 cloudfoundry/diego-release#690 cloudfoundry/diego-release#704 cloudfoundry/diego-release#728
ameowlia
pushed a commit
to cloudfoundry/community
that referenced
this pull request
May 30, 2023
…prover Diego Approver cloudfoundry/bbs#64 cloudfoundry/bbs#68 cloudfoundry/diego-dockerfiles@3aa03b8 cloudfoundry/diego-dockerfiles@77dccfa cloudfoundry/diego-dockerfiles@c69911c cloudfoundry/diego-dockerfiles@df0aed2 cloudfoundry/diego-release@05dcaba cloudfoundry/diego-release@390d5d7 cloudfoundry/diego-release@4d5e6a1 cloudfoundry/diego-release@5158007 cloudfoundry/diego-release#740 cloudfoundry/docs-cloudfoundry-concepts#181 cloudfoundry/dontpanic#39 cloudfoundry/executor#76 cloudfoundry/executor#80 cloudfoundry/grace#3 cloudfoundry/healthchecker-release#2 cloudfoundry/wg-app-platform-runtime-ci@03fa33d cloudfoundry/wg-app-platform-runtime-ci@3affeda PR Reviews: cloudfoundry/buildpackapplifecycle#55 cloudfoundry/cacheddownloader#18 cloudfoundry/diego-release#689 cloudfoundry/diego-release#690 cloudfoundry/diego-release#704 cloudfoundry/diego-release#728
dsabeti
pushed a commit
that referenced
this pull request
Aug 9, 2023
This is a follow up commit to: - #64 - e9001b4 In the original PR we accidentally modified a file that is automatically generated from the proto definition instead of modifying the proto defintion itself. [#183842469](https://www.pivotaltracker.com/story/show/183842469) Signed-off-by: David Sabeti <sabetid@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
cfdot
is not reporting emptyhost_tls_proxy_port
when C2c is utilizedcfdot actual-lrps
In the port section, each array entry should have 4 attributes. If there's no correpsonding port, it should list
0
as the port.For the C2CTLS port (61443), there is no entry for
host_tls_proxy_port
. This should be set to 0 in all cases (regardless of whether the values of thecontainers.proxy.enable_unproxied_port_mappings
andcontainers.proxy.require_and_verify_client_certificates
properties are set)What problem it is trying to solve?
This change will report
host_tls_proxy_port
when it is empty as well as populatedHow should this change be described in diego-release release notes?
The bbs now correctly reports empty port assignments when using C2C networking
Please provide any contextual information.
Tracker story for private repo183842469