With distributed tracing #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: cloudfoundry/bbs#64
winkingturtle-vmw
force-pushed
the
with-distributed-tracing
branch
from
16fe8d0 to
c7dcc77
Compare
Signed-off-by: Brandon Roberson <broberson@vmware.com> Signed-off-by: Nick Rohn <nrohn@vmware.com>
there seems to be no code-path that would do any logging for evacuation_handler
winkingturtle-vmw
force-pushed
the
with-distributed-tracing
branch
from
c7dcc77 to
66e2a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Update Rep logging calls to use new
WithTraceInfo()method, which appends antrace-idbased on theVCAP_REQUEST_ID. This will allow users to trace a request from Gorouter through Diego components. See cloudfoundry/lager@1e35ce1What problem it is trying to solve?
Allows operators to troubleshoot a workflow through multiple components of CF.
How should this change be described in diego-release release notes?
Add zipkin trace-id to Diego (using lager
WithTraceInfo()method).