-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable metrics for deploy config #2482
enable metrics for deploy config #2482
Conversation
448d876
to
1874004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! @fmoehler |
What is this change about?
We introduced deploy configs with Bosh CLI v7.5.0+. As this could potentially lead to unwanted deploy flags if the config is forgotten/enabled too long, we introduce a metrics that returns 1 in case a deploy config is uploaded.
Please provide contextual information.
https://github.com/cloudfoundry/docs-bosh/blob/master/content/deploy-config.md
What tests have you run against this PR?
Create Dev Release and checked the response of the metrics server
How should this change be described in bosh release notes?
The default metrics now return if a deploy config was uploaded or not to avoid it being forgotten
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@AttilaAlmasi