Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ahmed Hassanin as approver #795

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

max-soe
Copy link
Contributor

@max-soe max-soe commented Mar 14, 2024

Ahmed was now a reviewer in this working group for more than 9 month and contributed and review a lot of PRs. Further he joins the WG meetings regularly and try to catch up with all changes in the community.

List of own PRs: https://github.com/search?q=org%3Acloudfoundry+a-hassanin&type=pullrequests

Ahmed was now a reviewer in this working group for more than 9 month and contributed and review a lot of PRs. Further we joins the WG meetings regularly and try to catch up with all changes in the community.
@max-soe
Copy link
Contributor Author

max-soe commented Mar 14, 2024

@rkoster @beyhan can you please check?

@beyhan beyhan added the wg label Mar 14, 2024
@beyhan
Copy link
Member

beyhan commented Mar 14, 2024

@max-soe you can use the contributions-for-user.sh when you create role update prs for transparency. Here are the contributions of @a-hassanin:

Foundational Infrastructure: VM deployment lifecycle (BOSH) Contributions

PRs Commented on/Reviewed:

Issues that may be relevant:

Code contributions:

What I can see is that the contributions meet the approver requirements .

@beyhan beyhan self-requested a review March 14, 2024 12:12
@beyhan beyhan requested review from jpalermo and rkoster March 14, 2024 12:13
Copy link
Member

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpalermo jpalermo merged commit 32bec73 into cloudfoundry:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants