Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting instance group tags #793

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Supporting instance group tags #793

merged 1 commit into from
Jul 13, 2023

Conversation

a-hassanin
Copy link
Contributor

No description provided.

@rkoster rkoster requested review from a team, danielfor and klakin-pivotal and removed request for a team June 15, 2023 14:44
@rkoster
Copy link
Contributor

rkoster commented Jun 15, 2023

This PR is document the functionality from this PR: cloudfoundry/bosh#2448

@rkoster
Copy link
Contributor

rkoster commented Jun 15, 2023

Make sure the documented version matches when the above PR gets merged.

beyhan
beyhan reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@beyhan beyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but we need to coordinate the bosh version as Ruben mentioned.

@beyhan
Copy link
Member

beyhan commented Jun 23, 2023

The cloudfoundry/bosh#2448 has been merged and if everything is fine this will be available with v277.3.5, which is not yet merged.

@max-soe max-soe mentioned this pull request Jul 5, 2023
Merged
ramonskie
ramonskie approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ramonskie ramonskie merged commit b82aad3 into cloudfoundry:master Jul 13, 2023
@beyhan beyhan mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramonskie ramonskie ramonskie approved these changes

@beyhan beyhan beyhan approved these changes

@mvach mvach mvach approved these changes

@danielfor danielfor Awaiting requested review from danielfor danielfor was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@klakin-pivotal klakin-pivotal Awaiting requested review from klakin-pivotal klakin-pivotal was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@a-hassanin @rkoster @beyhan @mvach @ramonskie