When adding a new tombstone record, delete all the older ones #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpalermo
requested review from
a team,
ramonskie and
anshrupani
and removed request for
a team
selzoc
approved these changes
Jun 27, 2024
|
cool finding! 👍 |
|
This PR seems to be causing consistent Reformatted output from CI job above |
|
@aramprice @jpalermo should we open an issue for the above mentioned deadlocks or it is addressed already? |
jpalermo
added a commit
that referenced
this pull request
Jul 11, 2024
The tombstone creation happens in a larger transaction, so if you both insert and clean tombstone records at the same time you can end up in a deadlock state if that is happening in multiple threads at the same time. This commit moves the tombstone cleanup into a scheduled job that runs once a day instead.
|
New PR to move it to a scheduled job |
|
Thanks! @jpalermo this was faster than the light :-) |
|
Convenient timing 😀 |
aramprice
pushed a commit
that referenced
this pull request
Jul 11, 2024
The tombstone creation happens in a larger transaction, so if you both insert and clean tombstone records at the same time you can end up in a deadlock state if that is happening in multiple threads at the same time. This commit moves the tombstone cleanup into a scheduled job that runs once a day instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that these are never cleaned up currently. There may be a performance hit when the first new tombstone record is added and thousands of old ones are destroyed but it shouldn't be terrible.