Move local dns tombstone cleanup to scheduled job #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tombstone creation happens in a larger transaction, so if you both insert and clean tombstone records at the same time you can end up in a deadlock state if that is happening in multiple threads at the same time. This commit moves the tombstone cleanup into a scheduled job that runs once a day instead.
selzoc
approved these changes
Jul 11, 2024
rkoster
requested review from
a team,
mvach and
ramonskie
and removed request for
a team
ystros
approved these changes
Jul 11, 2024
aramprice
approved these changes
Jul 11, 2024
|
thanks @jpalermo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2533
The tombstone creation happens in a larger transaction, so if you both insert and clean tombstone records at the same time you can end up in a deadlock state if that is happening in multiple threads at the same time.
This commit moves the tombstone cleanup into a scheduled job that runs once a day instead.