🐞 Use Rake's sh method to execute TestRunner's command
#2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
rake-tasks-fail-when-specs-fail
branch
2 times, most recently
from
c80cf08
to
a7696a0
Compare
It turns out that using `TestRunner#unit_execute` with `parallel: true` always exits cleanly when called. Instead it passes back a hash containing an `error:` key. This change modifies the rake task to insead use Rake's built in `sh` method to execute the `parallel_test` commmand generated by `TestRunner` which allows the rake task to fail correctly when there are spec failures.
aramprice
force-pushed
the
rake-tasks-fail-when-specs-fail
branch
from
a7696a0
to
bfd7fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that using
TestRunner#unit_executewithparallel: truealways exits cleanly when called. Instead it passes back a hash containing anerror:key.This change modifies the rake task to insead use Rake's built in
shmethod to execute theparallel_testcommmand generated byTestRunnerwhich allows the rake task to fail correctly when there are spec failures.Note: this change exposes failures in Github Actions which were incorrectly passing: