Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Use Rake's sh method to execute TestRunner's command #2560

Merged
merged 2 commits into from
Sep 16, 2024
Merged

🐞 Use Rake's sh method to execute TestRunner's command #2560

merged 2 commits into from
Sep 16, 2024

Commits on Sep 16, 2024

  1. 🐞 Use Rake's sh method to execute TestRunner's command 

    It turns out that using `TestRunner#unit_execute` with `parallel: true`
always exits cleanly when called. Instead it passes back a hash
containing an `error:` key.

This change modifies the rake task to insead use Rake's built in `sh`
method to execute the `parallel_test` commmand generated by `TestRunner`
which allows the rake task to fail correctly when there are spec
failures.
    @aramprice
    aramprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6f80516 View commit details
    Browse the repository at this point in the history

  2. Make TestRunner#unit_exec private to prevent mis-use

    @aramprice
    aramprice committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bfd7fcc View commit details
    Browse the repository at this point in the history