Remove php buildpack config #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsabeti @aramprice I think this branch needs a rebase. |
This code is completely unused by CATs. Despite the fact that the config struct has a field for specifying the php buildpack, the config _interface_ does not expose a function for accessing the php buildpack name
dsabeti
force-pushed
the
remove-php-buildpack-config
branch
from
c5006aa to
c7a925f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes, however, this change does depend on first merging #697.
What is this change about?
The
php_buildpack_namefield is never used by CATs, so this PR removes all references to it. In fact, despite having this configuration parameter, the Config interface does not expose aGetPhpBuildpackName()function as it does with most other buildpacks, so we know programatically that this field is never used.(The PHP asset is used only in the
detecttest suite, where no buildpack name is specified on purpose -- the test exists to validate that a PHP app is successfully detected by CF even when the user does not explicitly specify a buildpack.)Please provide contextual information.
N/A
What version of cf-deployment have you run this cf-acceptance-test change against?
N/A
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
N/A
How many more (or fewer) seconds of runtime will this change introduce to CATs?
N/A
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@aramprice