Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python buildpack config #701

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

dsabeti
Copy link
Contributor

@dsabeti dsabeti commented Jan 10, 2023

Are you submitting this PR against the develop branch?

Yes, however, this change does depend on first merging #697.

What is this change about?

The python_buildpack_name field is never used by CATs, so this PR removes all references to it. In fact, despite having this configuration parameter, the Config interface does not expose a GetPythonBuildpackName() function as it does with most other buildpacks, so we know programatically that this field is never used.

(The Python asset is used only in the detect test suite, where no buildpack name is specified on purpose -- the test exists to validate that a Python app is successfully detected by CF even when the user does not explicitly specify a buildpack.)

Please provide contextual information.

N/A

What version of cf-deployment have you run this cf-acceptance-test change against?

N/A

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@aramprice

@ctlong
Copy link
Member

ctlong commented Jan 13, 2023

@dsabeti @aramprice I think this branch needs a rebase

@dsabeti dsabeti force-pushed the remove-python-buildpack-config branch from ec4560d to cac17c6 Compare January 17, 2023 23:59
@ctlong
Copy link
Member

ctlong commented Jan 18, 2023

@dsabeti @aramprice I think merging #700 created merge conflicts for this PR, and unfortunately another rebase is required.

This code is completely unused by CATs. Despite the fact that the config struct has a field for specifying the python buildpack, the config _interface_ does not expose a function for accessing the python buildpack name.
@dsabeti dsabeti force-pushed the remove-python-buildpack-config branch from cac17c6 to 640d7ad Compare January 18, 2023 01:11
@ctlong ctlong merged commit 1d26cf7 into cloudfoundry:develop Jan 18, 2023
@dsabeti dsabeti deleted the remove-python-buildpack-config branch January 18, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants