Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nginx timeout configurable #2138

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

johha
Copy link
Contributor

@johha johha commented Mar 2, 2021

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Currently the nginx timeout for graceful shutdown is hard coded to 30 secs. If requests take longer than this (e.g. v2/services on big foundries) they'll be terminated. Making this configurable will allow operators to prevent (too many) failed requests during monit restarts.

  • Links to any other associated PRs
    PR for capi-release: Shutdown nginx timeout capi-release#188

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

Co-authored-by: Philipp Thun <philippthun@users.noreply.github.com>
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177160167

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants