Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johha to ARI approvers #329

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

johha
Copy link
Contributor

@johha johha commented Jun 29, 2022

About Me

I'm a senior developer at SAP working together with @philippthun, @FloThinksPi, @jochenehret, @stephanme on operating and improving Capi and related projects.

Contributions

In the past ~18 months I was involved in a number for contributions, discussions etc. which qualifies me to be a approver for Capi.

CVEs

Label_selectors CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22101

Issues

Unusable Buildpacks: cloudfoundry/cloud_controller_ng#1625

Slack Conversations

Service credential bindings discussion: https://cloudfoundry.slack.com/archives/C07C04W4Q/p1640160640057900
Suspended orgs/ user permissions: https://cloudfoundry.slack.com/archives/C07C04W4Q/p1637252694022900

capi-release

Key rotation(merged manually): cloudfoundry/capi-release#119
Nginx timeout parameter: cloudfoundry/capi-release#188
Nginx drain parameter: cloudfoundry/capi-release#189
User header: cloudfoundry/capi-release#191
Job priorities parameter: cloudfoundry/capi-release#227
Access log escaping (co-author): cloudfoundry/capi-release#192
Fog debug environment variable (co-author): cloudfoundry/capi-release#185

cloud_controller_ng

Better error message for active org check (in progress, co-author): cloudfoundry/cloud_controller_ng#2570
CC worker logging (co-author): cloudfoundry/cloud_controller_ng#1995
Retry polling (co-author): cloudfoundry/cloud_controller_ng#2413
Deserialization spec for SpaceApplyManifestActionJob: cloudfoundry/cloud_controller_ng#2782
Logging of deserialization errors: cloudfoundry/cloud_controller_ng#2771
Configurable delayed job priorities: cloudfoundry/cloud_controller_ng#2693
Simplify roles query (co-author): cloudfoundry/cloud_controller_ng#2532
Logging of sql query lengths: cloudfoundry/cloud_controller_ng#2329
Logging of sql returned rows (co-author): cloudfoundry/cloud_controller_ng#2338
Window functions (co-author): cloudfoundry/cloud_controller_ng#2527
User guid header: cloudfoundry/cloud_controller_ng#2167
Enhance Nginx drain: cloudfoundry/cloud_controller_ng#2150
Nginx timeout: cloudfoundry/cloud_controller_ng#2138
Update fog-azure-rm dependency (co-author): cloudfoundry/cloud_controller_ng#1925

cf-performance-tests

Add pipeline for re-running old cf-d versions: cloudfoundry/cf-performance-tests-pipeline#23
Improve data generation in test setup: cloudfoundry/cf-performance-tests#17

@stephanme stephanme requested a review from Gerg June 29, 2022 07:27
@johha johha marked this pull request as ready for review June 29, 2022 07:48
Copy link
Member

@philippthun philippthun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having Johannes on board would be great!

@Gerg
Copy link
Member

Gerg commented Jun 29, 2022

Per https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0008-role-change-process.md#promotion-to-approver, you need 2 existing approvers to review your application. I see @philippthun already approved the promotion, so you will need one more.

Once that criteria is met, I'll merge this PR. Depending on the state of the Github teams automation, I may also need to update https://github.com/cloudfoundry/community/blob/ac5ce430d66098325a6b1fcf76356af17601ccad/org/cloudfoundry.yml to grant you access to the appropriate teams.

@Gerg Gerg merged commit a19de25 into cloudfoundry:main Jul 5, 2022
@Gerg
Copy link
Member

Gerg commented Jul 5, 2022

I'll make a follow-up PR to add @johha to the appropriate teams.

Gerg added a commit that referenced this pull request Jul 5, 2022
Follow up to [#329]

Authored-by: Greg Cobb <gcobb@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants