Fix broken major upgrade logic #70
Conversation
… that matches the major postgres version being upgraded from. If no package dir exists, because they are making a large upgrade jump, print an error and exit.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185816260 The labels on this github issue will be updated when the story is started. |
…ata directories exist, print an error and exit. We no longer have the postgres 9 packages to be able to upgrade from these versions. Users will have to upgrade to an older first first.
jpalermo
force-pushed
the
pr-issue-69-fix-upgrades
branch
from
b7cba29
to
ae5bc41
Compare
- The changes from tust to peer and md5 are a better security posture, but they break a lot of existing use cases and should probably instead be gated behind some sort of configuration flag. Co-located bbr relies upon passwordless connection to the database as vcap user, but runs a root. Many of the acceptance tests also try using the vcap user but run as root via ssh and fail with the changes. - Postgres 15 no longer grants users access to the public schema. This prevents generated users from being able to create tables. Update the create_databases function to grant access to the public schema for each role on each database.
|
Found two additional problems when trying to run the acceptance tests. The changes from Also, postgres 15 removes default access to the public schema for databases. This prevents the generated non-superuser roles from creating tables in the public schema (which is generally where most people create tables). This changes grants access to the public schema on each database for all roles created. |
Fixes for #69
We now find the current postgres package that matches the major version they are upgrading from. If no package is found, exit with error.
I also removed a lot of the older postgres 9 upgrade logic since the postgres 9 packages are no longer included in the release. So instead we just fail early if we find a data directory, but no version file.