Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major overhaul on acceptance test infrastructure and ci pipeline #72

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

jpalermo
Copy link
Member

This can't be merged yet due to the following blockers, but I wanted to get the PR started to get any feedback.

Things needed before this can be merged:

  • Rename develop to main and delete master branch.
  • Update the Foundation Infrastructure concourse to be able to run bosh-lite workloads
  • Not totally sure where the final release bucket lives, but it's not in the CFF account I have access to. So we'll either need to get access keys for that into the Concourse credhub, or we'll need to move to a bucket in the foundation account.

Changes:

  • Intent is to deploy this to the shared foundational infrastructure ci instance
  • As there is no longer a long lived bosh director, the acceptance tests now run in a bosh-lite environment directly in the CI container
  • CI has jobs for acceptance tests, automated weekly bumps for golang packages, automated bumps of postgres packages, and a job to cut a final release
  • All other CI pipelines and tasks have been removed
  • Acceptance tests have been updated to go mod and dependencies have been vendored
  • I've removed the "old" concept from the versions.yml and instead changed the helper to use the release two versions back as the old one. Not 100% sure this is correct behavior (and may cause problems due to v45 being broken), but it seems like testing n-2 to current will always catch problems caused by a major postgres bump.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/185846390

The labels on this github issue will be updated when the story is started.

- Intent is to deploy this to the shared foundational infrastructure ci instance
- As there is no longer a long lived bosh director, the acceptance tests now run in a bosh-lite environment directly in the CI container
- CI has jobs for acceptance tests, automated weekly bumps for golang packages, automated bumps of postgres packages, a job to cut a final release, and a job that detects postgres 15 package bumps and automatically triggers a release
- All other CI pipelines and tasks have been removed
- Acceptance tests have been updated to go mod and dependencies have been vendored
- I've removed the "old" concept from the versions.yml and instead changed the helper
  to use the release two versions back as the old one. Not 100% sure this is correct
  behavior (and may cause problems due to v45 being broken), but it seems like
  testing n-2 to current will always catch problems caused by a major postgres bump.
@jpalermo jpalermo force-pushed the pr-update-acceptance-tests-and-concourse-pipeline branch from 14270c1 to 4a4e6a0 Compare September 1, 2023 23:54
Copy link
Contributor

@Jobsby Jobsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side.
I have already clarified the open question with Joseph.
The changes make sense and I think they are good.
Thanks Joseph for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants