Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PostgreSQL 16 as new major and used release version #76

Merged
merged 4 commits into from
May 7, 2024

Conversation

ZPascal
Copy link
Contributor

@ZPascal ZPascal commented Apr 14, 2024

Description:

  • The PR adds PostgreSQL 16 to the release, adjusts the CI/CD pipeline, and sets it as the new version in use

TODO:

  • Upload the Blobs for PostgreSQL release to the blob store (missing S3 credentials) @beyhan Can you please support me here?
  • Test the dev release

Follow-up

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187427001

The labels on this github issue will be updated when the story is started.

@beyhan
Copy link
Member

beyhan commented Apr 15, 2024

There is an automation which was introduced for release build with #72 and it will upload the blobs.

@ZPascal
Copy link
Contributor Author

ZPascal commented Apr 30, 2024

@beyhan Are you sure that the upload also works in a scratch case? I've got the S3 credentials and can upload the blobs to the blob store.

@ZPascal
Copy link
Contributor Author

ZPascal commented Apr 30, 2024

Hi @jpalermo, could you please review the PR?

@beyhan
Copy link
Member

beyhan commented Apr 30, 2024

Are you sure that the upload also works in a scratch case? I've got the S3 credentials and can upload the blobs to the blob store.

For me it looks like that it will work in general but I'm not sure about this line

bosh remove-blob ${OLD_BLOB_PATH}
because OLD_BLOB_PATH will be empty whether the bosh remove-blob command fails it that case. @jpalermo is this intended to do the upload also for the initial major version release?

Copy link
Member

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpalermo jpalermo merged commit 762a2e0 into cloudfoundry:main May 7, 2024
1 check passed
@ZPascal ZPascal deleted the add-postgresql-16 branch May 7, 2024 21:22
@jpalermo
Copy link
Member

jpalermo commented May 7, 2024

v50 was just cut that should have postgres 16 as the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants