Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent undefined error when seek-thumbnails are unavailable #635

Merged
merged 1 commit into from
May 26, 2024
Merged

fix: prevent undefined error when seek-thumbnails are unavailable #635

merged 1 commit into from
May 26, 2024

Conversation

tsi
Copy link
Collaborator

@tsi tsi commented May 22, 2024

No description provided.

@tsi tsi self-assigned this May 22, 2024
@tsi tsi requested a review from a team as a code owner May 22, 2024 11:11
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit ca971f5
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/664dd2e664ff170008b64a0d
😎 Deploy Preview https://deploy-preview-635--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit ca971f5
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/664dd2e670ae2100087daa40
😎 Deploy Preview https://deploy-preview-635--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tsi tsi requested review from jakub-roch and ehab-cl May 22, 2024 15:00
@tsi tsi merged commit f07df6b into edge May 26, 2024
9 checks passed
@tsi tsi deleted the ME-16728-undefined-error branch May 26, 2024 11:40
@cloudinary-jenkins cloudinary-jenkins mentioned this pull request May 26, 2024
Merged
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
Merge branch 'edge'
d5f7a77 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
fix: handle live streams (#641)
1b04cc8 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
This was referenced Jun 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-roch jakub-roch jakub-roch approved these changes

@ehab-cl ehab-cl Awaiting requested review from ehab-cl

Assignees

@tsi tsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsi @jakub-roch