Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text track with no src should fall-back to transcript #640

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: text track with no src should fall-back to transcript #640

merged 1 commit into from
Jun 6, 2024

Conversation

tsi
Copy link
Collaborator

@tsi tsi commented Jun 5, 2024

This PR introduces a small change to the transcript fetching logic.
Previously we fetched transcript only if maxWords or wordHighlight were configured, but in reality you might want the transcript without any of those.
This changes the condition so that if a text-track is configured without specifying a src it will try fetching the transcript file

@tsi tsi self-assigned this Jun 5, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 5, 2024 •
edited
Loading

✅ Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 1706a24
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6660375baeed2d0008a131ce
😎 Deploy Preview https://deploy-preview-640--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 5, 2024 •
edited
Loading

✅ Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 1706a24
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/6660375b436fe80008729f8c
😎 Deploy Preview https://deploy-preview-640--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tsi tsi marked this pull request as ready for review June 5, 2024 12:31
@tsi tsi requested a review from a team as a code owner June 5, 2024 12:31
@tsi tsi requested review from jakub-roch and ehab-cl June 5, 2024 12:31
@tsi tsi merged commit 35e54d9 into edge Jun 6, 2024
9 checks passed
@cloudinary-jenkins cloudinary-jenkins mentioned this pull request Jun 6, 2024
Merged
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
Merge branch 'edge'
d5f7a77 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
tsi added a commit that referenced this pull request Jun 10, 2024
@tsi
fix: handle live streams (#641)
1b04cc8 
fix: handle live streams (#641)

fix: text track with no src should fall-back to transcript (#640)

fix: bump video analytics, trigger analytics event only once (#637)

fix: prevent undefined error when seek-thumbnails are unavailable (#635)
This was referenced Jun 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehab-cl ehab-cl ehab-cl approved these changes

@jakub-roch jakub-roch Awaiting requested review from jakub-roch

Assignees

@tsi tsi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsi @ehab-cl