Skip to content

Commit

Permalink
Merge pull request #157 from Vacant2333/sg-ids
Browse files Browse the repository at this point in the history
chore: use SecurityGroupIds instad of SecurityGroupId for ProvisionGroup
  • Loading branch information
jwcesign authored Dec 3, 2024
2 parents c5ad91c + 159d93d commit 9d0df18
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions pkg/providers/instance/instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -533,14 +533,10 @@ func (p *DefaultProvider) getProvisioningGroup(ctx context.Context, nodeClass *v
AutoProvisioningGroupType: tea.String("instant"),
LaunchConfiguration: &ecsclient.CreateAutoProvisioningGroupRequestLaunchConfiguration{
// TODO: we should set image id for each instance types after alibabacloud supports
ImageId: tea.String(imageID),
SecurityGroupIds: securityGroupIDs,
UserData: tea.String(userData),

// TODO: AutoProvisioningGroup is not compatible with SecurityGroupIds, waiting for Aliyun developers to fix it,
// so here we only take the first one.
ImageId: tea.String(imageID),
UserData: tea.String(userData),
ResourceGroupId: tea.String(nodeClass.Spec.ResourceGroupID),
SecurityGroupId: securityGroupIDs[0],
SecurityGroupIds: securityGroupIDs,
SystemDiskSize: systemDisk.Size,
SystemDiskPerformanceLevel: systemDisk.PerformanceLevel,
Tag: reqTags,
Expand Down

0 comments on commit 9d0df18

Please sign in to comment.