Fixes #207, supplying AWS_DEFAULT_REGION fixes v0.12 tf validate
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2020
osterman
reviewed
May 7, 2020
osterman
reviewed
May 7, 2020
osterman
pushed a commit
to cloudposse/test-harness
that referenced
this pull request
May 7, 2020
* Adds prerequisites to README * Fixes validate.bats issue with "region" error for modules. This is the same issue as cloudposse/build-harness#208. Without a default region, `terraform validate` fails when running against independent modules as they do not have a provider/region supplied. * Fixes validate.bats unsetting the wrong environment var I believe this was just a mistake but I may be wrong. setup() sets TF_CLI_ARGS_init, but teardown unsets TF_CLI_ARGS_plan. That seemed like a small typo to me, so I figured I would include this.
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Erik Osterman <erik@cloudposse.com>
|
@osterman ping on this one. |
|
@osterman any interest in this? Totally fine to close out if not needed. It's been a while and I personally don't need it any longer. |
|
Closing out due to age and not being needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
terraform/validatetarget to actually runterraform validateinstead of logging "unsupported" message.why
AWS_DEFAULT_REGION.references