Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README template to pass lint and add gh action superlinter #232

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Update README template to pass lint and add gh action superlinter #232

merged 5 commits into from
Jul 30, 2020

Conversation

3h4x
Copy link

@3h4x 3h4x commented Jul 30, 2020

what

  • superlinter fix

why

In PR against terraform-example-module I ran into issue with superlint

ERROR:[README.md:240 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]]

Here is documentation about it:
https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md046---code-block-style

Passing check after manual changes introduced in this PR:
https://github.com/cloudposse/terraform-example-module/pull/3/checks?check_run_id=928418728

marcin added 2 commits July 30, 2020 17:51
Update README template to pass lint
3e3c0c3 
In PR against `terraform-example-module` I ran into [issue with superlint](https://github.com/cloudposse/terraform-example-module/pull/3/checks?check_run_id=928328375)
> ERROR:[README.md:240 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]]

Here is documentation about it:
https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md046---code-block-style
Additional fix for another lint failure
19f3343
@3h4x 3h4x requested review from a team as code owners July 30, 2020 15:59
@github-actions github-actions bot requested review from aknysh and goruha July 30, 2020 16:00
@osterman
Copy link
Member

image

We want the license to render like this. This will break that.

@3h4x
Copy link
Author

3h4x commented Jul 30, 2020

image

We want the license to render like this. This will break that.

Why is that? Other licenses are not looking like that (MIT, ISC, GNU), they're simple text. I did changes to unify how licenses are displayed across our repos.
@osterman If you want to stick with such render though I can disable lint check on it.

@3h4x 3h4x mentioned this pull request Jul 30, 2020
Merged
@3h4x 3h4x changed the title Update README template to pass lint Update README template to pass lint and add gh action superlinter Jul 30, 2020
@3h4x 3h4x requested a review from osterman July 30, 2020 19:25
@3h4x 3h4x merged commit e18caa6 into master Jul 30, 2020
ray-harris added a commit to stolostron/build-harness that referenced this pull request Nov 16, 2021
@ray-harris @schmidtd
@aknysh @hassenius @osterman @cloudpossebot @Gowiem @Nuru @maximmi @mcalhoun @SweetOps @lorengordon
merge upstream (#3)
cefdd3c 
* Let build-harness know what OS we're on (cloudposse#195)

* Add Slash Command Dispatch GitHub Actions template (cloudposse#197)

* Update Slash Command Dispatch GitHub Actions templates

* Update Slash Command Dispatch GitHub Actions templates

* Update Slash Command Dispatch GitHub Actions template

* suppress detachedhead advise on versioned tag install (cloudposse#199)

Thanks! Makes sense...

* Add discourse badges (cloudposse#200)

* fix gomplate install

* rebuild readme

* Update README.md (cloudposse#201)

Co-authored-by: osterman <osterman@users.noreply.github.com>

Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
Co-authored-by: osterman <osterman@users.noreply.github.com>

* Fixes cloudposse#149, tf/lint on mac xargs does not support --no-run-if-empty (cloudposse#206)

* fix dispatch template paths (cloudposse#211)

* fix dispatch template paths

* remove duplicate target

* Use github actions to build and push (cloudposse#213)

* Use github actions to build and push

* Update readme

* rename to docker

* rename to docker

* update descriptions

* build-and-push

* Update readme

* more renaming

* Update .github/workflows/build-and-push.yml

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* fix issue template (cloudposse#215)

* add test workflow (cloudposse#212)

* add test workflow

* bump versions

* add test command

* rename to chatops

* drop slash command (cloudposse#216)

* Update codeowners (cloudposse#217)

* Fix terraform docs (cloudposse#218)

* build image on releases (cloudposse#219)

* Fix assert-set (cloudposse#220)

* Fix assert-set

* Update description

* use native make to test variables

* reenable deps-dev

* use native make error handling

* add yq (cloudposse#222)

* Changes to support README.md to passing super-linter (cloudposse#230)

* MD changes to pass linting

* Additional changes

* Built readme

* CR changes

* Create ignore file by default

* Change description to better match docs/deps

* Change linter ignore to according type

* Fix MD040/fenced-code-language lint error

* Ignore just part of violating MD file

* Ignore MD041 for whole file targets.md

* Ignore linting all docs/*.md files

* Update README template to pass lint and add gh action superlinter  (cloudposse#232)

* Update README template to pass lint

In PR against `terraform-example-module` I ran into [issue with superlint](https://github.com/cloudposse/terraform-example-module/pull/3/checks?check_run_id=928328375)
> ERROR:[README.md:240 MD046/code-block-style Code block style [Expected: fenced; Actual: indented]]

Here is documentation about it:
https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md046---code-block-style

* Additional fix for another lint failure

* Convert licenses to code and add superlint to gh actions

* Fix readme

* Remove ending white characters'

* add auto-release action (cloudposse#238)

* refine auto release (cloudposse#239)

* Expand auto-releasers configuration (cloudposse#240)

* use labels

* fix auto labels

* Update Release Template (cloudposse#241)

* Update chatops (cloudposse#236)

* update chatops permissions

* update chatops

* Update .github/workflows/chatops.yml

Co-authored-by: Nuru <Nuru@users.noreply.github.com>

* Update .github/workflows/chatops.yml

Co-authored-by: Nuru <Nuru@users.noreply.github.com>

* update slash-command-dispatch

Co-authored-by: Nuru <Nuru@users.noreply.github.com>

* Fix module upgrade script (cloudposse#243)

* Fix module upgrade script

* update deps

* Add context.tf to CODEOWNERS (cloudposse#245)

* Fixing superlint terraform docs check for inherited markdown files (cloudposse#244)

* Update auto-release and docker workflow to push release tags (cloudposse#249)

* terraform/migrate-to-registry Makefile target added (cloudposse#258)

* terraform/migrate-to-registry Makefile target added

* target renamed

* readme rebuilded

* markdown linter rules fix to avoid raising errors for lines longer then 400 chars

* full linter config applied

* terraform format for examples as well

* markdownlint disabled for contributors table

* regex fix

* readme fix

* readme fix

* linter rules removed, no need for them any more

* new target to remove upper bound for terraform core version constraint (cloudposse#261)

* Add support for Terraform 0.14 (cloudposse#262)

* fix broken interpolation (cloudposse#265)

* Add commands to help create pull requests (cloudposse#266)

* Add renovate config to Terraform modules (cloudposse#267)

* Support more automation (cloudposse#268)

* RUNNER_DOCKER_IMAGE was missing for 'builder' target (cloudposse#269)

* [auto-context] Open PR (as cloudpossebot) when context.tf changes (cloudposse#270)

* feat: add dynamic update the lists of related and references (cloudposse#273)

* Update README.md Template with BridgeCrew Compliance Badges (cloudposse#256)

* Update README.md Template with BridgeCrew Compliance Badges

* template fixes

* Security & Compliance section shown only for terraform modules

Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>

* approvers now allowed to review all *.tf files (cloudposse#277)

* approvers now allowed to review all *.tf files

* README.yaml added for approvers

* mergify rule to close PRs without changes (cloudposse#280)

* mergify rule to close PRs without changes

* Update templates/terraform/.github/mergify.yml

Co-authored-by: Erik Osterman (CEO @ Cloud Posse) <erik@cloudposse.com>

* nightly build added before midnight to prepare build-harness images before most of nightly build fires (cloudposse#281)

* integration of generate-related-references target (cloudposse#282)

* remove generate-related-references target from auto-format (cloudposse#283)

* auto-release respect 'no-release' label (cloudposse#279)

* Adds auto-init capability using the bootstrap include directive (cloudposse#272)

* bugfix (cloudposse#285)

* Add `make` target to run pre-commit hooks (cloudposse#286)

* Add support for "deprecated" flag/section in README (cloudposse#288)

* Better formatting of combined release notes (cloudposse#289)

* Better formatting of combined release notes

* add conditional to related section or README template (cloudposse#290)

* add conditional

* fix formatting

* update readme

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>

* Add Terraform versions 0.15 and 1.x (cloudposse#293)

* Enable formatting of modules requiring TF 0.15 or TF 1. (cloudposse#294)

* Create a draft release rather than no release with `no-release` label (cloudposse#296)

* update AWS CLI (cloudposse#297)

* Make 1.x the default Terraform version (cloudposse#299)

* remove  target

* remove .github directory

Co-authored-by: David Schmidt <51931019+schmidtd@users.noreply.github.com>
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: Hans Kristian Moen <hassenius@users.noreply.github.com>
Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
Co-authored-by: osterman <osterman@users.noreply.github.com>
Co-authored-by: Matt Gowie <gowie.matt@gmail.com>
Co-authored-by: marcin <marcin@cloudposse.com>
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Co-authored-by: Maxim Mironenko <maxim@cloudposse.com>
Co-authored-by: Matt Calhoun <matt@cloudposse.com>
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
Co-authored-by: Loren Gordon <lorengordon@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
@Nuru Nuru deleted the update-readme-apache-license-lint branch November 18, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

@aknysh aknysh Awaiting requested review from aknysh

@goruha goruha Awaiting requested review from goruha

Assignees

@3h4x 3h4x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3h4x @osterman