Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions for precommit and lint #3

Merged
merged 7 commits into from
Aug 4, 2020

Conversation

3h4x
Copy link

@3h4x 3h4x commented Jul 30, 2020

what

  • github actions workflow for pre-commit and lint

why

  • to make it easy to comply with our standards

@3h4x 3h4x requested review from osterman, a team and nitrocode and removed request for a team July 30, 2020 15:31
osterman
osterman previously approved these changes Jul 30, 2020
@3h4x
Copy link
Author

3h4x commented Jul 30, 2020

@osterman This PR is WIP because it's blocked on build-harness PR
cloudposse/build-harness#232

It relies on it as github actions are tied to specific build harness version

- uses: cloudposse/build-harness@0.38.0

Let's first agree on build-harness PR and after release I will update this PR.

@3h4x 3h4x marked this pull request as ready for review July 30, 2020 20:00
@3h4x 3h4x requested a review from a team as a code owner July 30, 2020 20:00
.github/workflows/lint.yml Outdated Show resolved Hide resolved
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@3h4x 3h4x merged commit bc8a746 into master Aug 4, 2020
@3h4x 3h4x deleted the github-actions-with-lint-and-precommit branch August 4, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants