Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of cluster name from aurora ssm parameter #1162

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

darrenl33
Copy link
Contributor

what

  • ssm parameter is prefixed with the cluster name, adding an cluster_name_override to not set
  • allows prefix to follow naming convention for other parameters by only using ssm_path_prefix

@darrenl33 darrenl33 requested review from a team as code owners October 16, 2024 21:52
@Benbentwo
Copy link
Member

Does this work for you?

allows prefix to follow naming convention for other parameters by only using ssm_path_prefix

this currently would still have something between the ssm_path_prefix and the /user.

@goruha
Copy link
Member

goruha commented Nov 6, 2024

@darrenl33, why do we need this?
Could you pls provide any use-cases for this PR?

Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comment

@goruha goruha merged commit 5e6711f into cloudposse:main Nov 7, 2024
4 checks passed
goruha added a commit to cloudposse-terraform-components/aws-aurora-postgres that referenced this pull request Nov 27, 2024
…erraform-aws-components#1162)

Co-authored-by: Benjamin Smith <ben.smith.developer@gmail.com>
Co-authored-by: Igor Rodionov <goruha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants