Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of cluster name from aurora ssm parameter #1162

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Allow removal of cluster name from aurora ssm parameter #1162

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c8e61c3
allow removal of cluster name from aurora ssm parameter
darrenl33 Oct 16, 2024
d2d2cc6
update conditional
darrenl33 Oct 16, 2024
1b6df57
update variable for ssm_cluster_name_override
darrenl33 Oct 16, 2024
33d9a02
Apply suggestions from code review
darrenl33 Oct 16, 2024
80f77ad
Update variables.tf
darrenl33 Oct 16, 2024
a590f19
update conditional expression to type of bool
darrenl33 Oct 16, 2024
d893134
Merge branch 'main' into aurora-ssm-cluster-name
Benbentwo Oct 17, 2024
ad67239
Merge branch 'main' into aurora-ssm-cluster-name
goruha Nov 6, 2024
b0378ee
Merge branch 'main' into aurora-ssm-cluster-name
goruha Nov 6, 2024
245e777
Merge branch 'main' into aurora-ssm-cluster-name
goruha Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/aurora-postgres/ssm.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
locals {
ssm_path_prefix = format("/%s/%s", var.ssm_path_prefix, module.cluster.id)
ssm_path_prefix = var.ssm_cluster_name_override ? format("/%s", var.ssm_path_prefix) : format("/%s/%s", var.ssm_path_prefix, module.cluster.id)
darrenl33 marked this conversation as resolved.
Show resolved Hide resolved

admin_user_key = format("%s/%s/%s", local.ssm_path_prefix, "admin", "user")
admin_password_key = format("%s/%s/%s", local.ssm_path_prefix, "admin", "password")
Expand Down
6 changes: 6 additions & 0 deletions modules/aurora-postgres/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,3 +352,9 @@ variable "backup_window" {
default = "07:00-09:00"
description = "Daily time range during which the backups happen, UTC"
}

variable "ssm_cluster_name_override" {
type = bool
default = false
description = "If set to true, we don't set cluster name into ssm parameter store name"
}