Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take over from #66 with suggestions #82

Closed
wants to merge 3 commits into from
Closed

Take over from #66 with suggestions #82

wants to merge 3 commits into from

Conversation

mwarkentin
Copy link
Contributor

@mwarkentin mwarkentin commented Apr 28, 2021 •
edited
Loading

what

  • This feature will allow setting replica configurations for aws_dynamodb_table resource.

why

  • According to the note at AWS provider v3.4.0 docs, it's recommended to use replica configuration instead of aws_dynamodb_global_table resource and there is a lack of that functionality in this module.

references

@mwarkentin mwarkentin requested review from a team as code owners April 28, 2021 20:09
@mwarkentin mwarkentin requested review from jhosteny and brcnblc April 28, 2021 20:09
mwarkentin
mwarkentin commented Apr 28, 2021
View reviewed changes
README.yaml
@@ -154,6 +154,8 @@ usage: |2-
non_key_attributes = ["HashKey", "RangeKey"]
}
]

replicas = ["us-east-1"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried running make readme but got this:

❯ make readme
* Package gomplate already installed
* Package terraform-docs already installed
make: gomplate: No such file or directory
make: *** [readme/build] Error 1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you forgot to run make init. btw you can open PR from your account (not organisation) to make it possible for our bot to generate README

@mwarkentin
Copy link
Contributor Author

@SweetOps looked like the other PR was stale / unresponsive - ok if I take this over?

@SweetOps
Copy link

/test readme

@SweetOps
Copy link

/rebuild-readme

@mwarkentin mwarkentin mentioned this pull request Apr 29, 2021
Merged
@mwarkentin
Copy link
Contributor Author

@SweetOps opened #83 from my personal account instead

@mwarkentin mwarkentin closed this Apr 29, 2021
@mwarkentin mwarkentin deleted the dynamodb-table-replica-support branch April 29, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global Table regions
2 participants
@mwarkentin @SweetOps