-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamodb table replica support #83
Dynamodb table replica support #83
Conversation
/test all |
FYI, I haven't tested these changes myself yet, working on getting a terraform 0.13 environment set up to test (we're in the middle of upgrading from 12 -> 13 right now). |
Co-authored-by: Vladimir <vladimir.fess@gmail.com>
/test all |
stream_enabled = var.enable_streams | ||
stream_view_type = var.enable_streams ? var.stream_view_type : "" | ||
stream_enabled = length(var.replicas) > 0 ? true : var.enable_streams | ||
stream_view_type = length(var.replicas) > 0 || var.enable_streams ? var.stream_view_type : "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe for global tables stream_view_type
needs to be NEW_AND_OLD_IMAGES
- is that something we want to configure automatically or just document and expect the user to pass in?
Looks like there's some
Edit: looks like there's an open issue for this: hashicorp/terraform-provider-aws#13097 Edit 2: Can create from scratch without an issue when using |
/test all |
@SweetOps ready for another look whenever you're around. I've tested:
|
/test all |
/test all |
@SweetOps thanks! |
what
why
references