Add unicity to alert names using instance ID (#5) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
requested changes
Mar 6, 2019
There was a problem hiding this comment.
You're totally correct in submitting this PR and this needs to be addressed. Unfortunately, I need to ask that we use the terraform-null-label module (or terraform-terraform-label module - your pick) to generate all the labels for consistency with all of our other modules.
|
@rebelthor thanks, any update on this? |
elliottyates
added a commit
to harvard-dart/terraform-aws-rds-cloudwatch-sns-alarms
that referenced
this pull request
Feb 5, 2020
…arm names to support multiple RDS clusters in a single account - cf cloudposse#10
elliottyates
added a commit
to harvard-dart/terraform-aws-rds-cloudwatch-sns-alarms
that referenced
this pull request
Feb 5, 2020
…arm names to support multiple RDS clusters in a single account - cf cloudposse#10
|
This pull request is now in conflict. Could you fix it @rebelthor? 🙏 |
|
Superseded by #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #5 by using the instance ID in the alert names for unicity.