feature: allow monitoring multiple RDS instances #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: unique labels for alarms
- add separate labels for each alarm - minor cleanup
…ws-rds-cloudwatch-sns-alarms into DevopsCare-master
…ws-rds-cloudwatch-sns-alarms into DevopsCare-master
joe-niland
requested review from
dotCipher and
woz5999
and removed request for
a team
joe-niland
changed the title
|
/test all |
|
/test bats |
|
/test terratest |
|
/test bats |
|
@joe-niland Can you run /test bats again as the results have expired, would be interested to see why this is failing. |
|
/test bats |
|
@joe-niland I think its an issue with the test itself, isn't it? Can't configure provider. |
|
/test bats |
|
@JohnShortland yes that's true. Looking into it. |
|
bump |
|
This pull request is now in conflict. Could you fix it @joe-niland? 🙏 |
|
/test all |
…ws-rds-cloudwatch-sns-alarms into DevopsCare-master
|
/test bats |
…ws-rds-cloudwatch-sns-alarms into DevopsCare-master
|
/test bats |
|
/test all |
|
/test all |
jamengual
reviewed
Jul 3, 2022
…ws-rds-cloudwatch-sns-alarms into DevopsCare-master
|
/test all |
nitrocode
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references