Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #21

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Improve documentation #21

merged 1 commit into from
Mar 8, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Feb 9, 2024

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yadaiio
Copy link
Contributor Author

yadaiio commented Feb 13, 2024

Thanks for noticing this @clue. Should be fixed now. 👍

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -120,12 +130,12 @@ try {
}
```

Similarly, you can also process multiple lookups concurrently and await an array of results:
Similarly, you can also process multiple resolves concurrently and await an array of results:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, I prefer the previous version, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought since I changed the lookup in the code, I thought it would add up to change the describing text above, but it is also okay to use this here. I changed it now @clue

examples/lookup.php Outdated Show resolved Hide resolved
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v0.2.1 milestone Mar 8, 2024
@clue clue merged commit 576236a into clue:master Mar 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants