Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and examples #20

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Improve documentation and examples #20

merged 1 commit into from
Feb 3, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 17, 2024

This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of: clue/reactphp-sqlite#43.

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Jan 22, 2024
@SimonFrings SimonFrings added this to the v0.3.0 milestone Jan 22, 2024
@yadaiio yadaiio changed the title Fix typos in documentation Imrove documentation and fix typos Jan 26, 2024
@yadaiio yadaiio changed the title Imrove documentation and fix typos Improve documentation and fix typos Jan 26, 2024
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this PR, added a few remarks below 👍

These changes look similar to clue/reactphp-sqlite#43, maybe include a reference to this ticket in your description and update the title?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yadaiio yadaiio changed the title Improve documentation and fix typos Improve documentation and examples Jan 26, 2024
@yadaiio
Copy link
Contributor Author

yadaiio commented Jan 26, 2024

Thank you @SimonFrings for informing me about this. Changes should be okay by now, I also changed the title of this pull request and added the references. Thank you 👍

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants