Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and examples #20

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Jan 30, 2024

This pull request builds on top of: clue/reactphp-sqlite#43 and clue/reactphp-tar#20.

README.md Outdated
```

To run the test suite, go to the project root and run:

```bash
$ php vendor/bin/phpunit
php vendor/bin/phpunit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we use this version in other projects, should be apply the same here?

Suggested change
php vendor/bin/phpunit
vendor/bin/phpunit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for noticing this, should be fixed now.

@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch 2 times, most recently from 98949b0 to 47b17b1 Compare February 2, 2024 10:56
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just noticed that examples/php.php could also need rejection handling, similar as you already did this in examples/bash.php & examples/docker.php

@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 47b17b1 to e4dd429 Compare February 6, 2024 07:41
@yadaiio
Copy link
Contributor Author

yadaiio commented Feb 6, 2024

oops, didn't saw the then in there 🤗 should also has a rejection handling now, thanks @SimonFrings

Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the requested changes, looks good to me 👍

@clue clue added the documentation Improvements or additions to documentation label Feb 7, 2024
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants