Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #23

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Improve documentation #23

merged 1 commit into from
Mar 25, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Mar 21, 2024

Builds on top of #12 and #22.

References: clue/reactphp-tar#20, clue/reactphp-redis#117, clue/reactphp-shell#20 and clue/reactphp-sqlite#43.

As I saw the link was currently broken in line 117 as we were referring to the PHP 5.4 features, I decided to write a ticket to the maintainers of the documentation page of PHP for asking if this was intentionally, see php/doc-en#3280. They confirmed it and gave me another link. I chose to use this as a reference here. WDYT about this @clue ?

The officially announcement of making this decision for PHP 5+ can be read here: https://www.php.net/manual/php5.php

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v1.2.0 milestone Mar 25, 2024
@clue clue added the documentation Improvements or additions to documentation label Mar 25, 2024
@clue clue merged commit fdd6c0d into clue:master Mar 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants