Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pediacluster status.Version as optional field. #333

Closed
wuyingjun-lucky opened this issue Aug 30, 2022 · 14 comments · Fixed by #373
Closed

Mark pediacluster status.Version as optional field. #333

wuyingjun-lucky opened this issue Aug 30, 2022 · 14 comments · Fixed by #373
Assignees
Labels
good first issue Good for newcomers kind/feature New feature

Comments

@wuyingjun-lucky
Copy link
Member

wuyingjun-lucky commented Aug 30, 2022

What would you like to be added?

Mark pediacluster status.Version as optional field. See as #328

Why is this needed?

Version


   // +required
   // +kubebuilder:validation:Required
   Version string `json:"version,omitempty"`

The Version can not mark as required field with omitempty tag otherwise it can not generate a required field in CRD

@wuyingjun-lucky wuyingjun-lucky added the kind/feature New feature label Aug 30, 2022
@github-actions
Copy link

Hi @wuyingjun-lucky,
Thanks for opening an issue!
We will look into it as soon as possible.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber
Copy link
Member

Iceber commented Aug 30, 2022

/good-first-issue

@github-actions github-actions bot added the good first issue Good for newcomers label Aug 30, 2022
@KUANG-CHENG
Copy link

/assign

@github-actions
Copy link

@KUANG-CHENG

Assign to KUANG-CHENG
Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@wzshiming
Copy link
Member

Testing robot, please ignore

/unassign KUANG-CHENG

@wzshiming
Copy link
Member

Testing robot, please ignore

/assign KUANG-CHENG

@wuyingjun-lucky
Copy link
Member Author

Testing robot, please ignore

/assign KUANG-CHENG

@wzshiming @Iceber
Hi
Can we modify the robot name like clusterpedia-bot or cp-bot

@wzshiming
Copy link
Member

Testing robot, please ignore
/assign KUANG-CHENG

@wzshiming @Iceber Hi Can we modify the robot name like clusterpedia-bot or cp-bot

Of course, register a GitHub account with the desired name, and configure its TOKEN here

GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@Iceber
Copy link
Member

Iceber commented Sep 1, 2022

Of course, register a GitHub account with the desired name, and configure its TOKEN here

This requires a separate account or a separate server to run the github apps.
But the api limitations of a separate normal account are greater than github action, and we don't have our own separate server yet.

@wuyingjun-lucky We could support this in the future, which is a good idea.

@wuyingjun-lucky
Copy link
Member Author

@KUANG-CHENG you can go on with this job

@Iceber
Copy link
Member

Iceber commented Sep 15, 2022

@KUANG-CHENG Hi, if you have any questions, we can discuss together.

@KUANG-CHENG
Copy link

I'm sorry I haven't submitted it so late. I've done the issue and when the mailbox comes down, I'll submit it in about three or four days as soon as possible. @Iceber

kuangcheng66 pushed a commit to kuangcheng66/clusterpedia that referenced this issue Sep 16, 2022
@kuangcheng66
Copy link
Contributor

/assign

@Iceber
Copy link
Member

Iceber commented Sep 16, 2022

@KUANG-CHENG HI, This issue has been fixed.
If you're interested, we have a good first issue #365 to fix, and your contributions are welcome!

Iceber added a commit that referenced this issue Sep 17, 2022
Mark pediacluster status.Version as optional field.#333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants