Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark pediacluster status.Version as optional field.#333 #373

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

kuangcheng66
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
mark pediacluster status.version as optional field

Which issue(s) this PR fixes:
Fixes #333

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @kuangcheng66,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

Signed-off-by: kuangcheng <kuangcheng_yewu@cmss.chinamobile.com>
@kuangcheng66
Copy link
Contributor Author

/cc @Iceber hello, please approve running workflows.

@Iceber
Copy link
Member

Iceber commented Sep 16, 2022

/retest

@Iceber
Copy link
Member

Iceber commented Sep 16, 2022

/lgtm
@kuangcheng66 Thanks for your contribution and look forward to more of your participation

@clusterpedia-bot clusterpedia-bot added the lgtm Look good to me label Sep 16, 2022
@Iceber Iceber merged commit d5cc726 into clusterpedia-io:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Look good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark pediacluster status.Version as optional field.
3 participants